Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generic_mount_paths field #18558

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

maxb
Copy link
Contributor

@maxb maxb commented Dec 27, 2022

PR #17926 already deleted the implementation of the
generic_mount_paths field so it needs to be removed from the declared
fields of the path too, so help and OpenAPI isn't misleading.

PR hashicorp#17926 already deleted the implementation of the
`generic_mount_paths` field so it needs to be removed from the declared
fields of the path too, so help and OpenAPI isn't misleading.
@maxb
Copy link
Contributor Author

maxb commented Dec 29, 2022

Please label pr/no-changelog

@averche averche self-assigned this Jan 3, 2023
@averche
Copy link
Contributor

averche commented Jan 3, 2023

This is a good catch, thank you for contributing!

@maxb
Copy link
Contributor Author

maxb commented Jan 3, 2023

Thanks for the approval - do I need to do anything more for this to be merged?

@averche averche merged commit 79c8f62 into hashicorp:main Jan 4, 2023
@maxb maxb deleted the leftover-generic_mount_paths branch January 4, 2023 05:23
averche added a commit that referenced this pull request Jan 6, 2023
averche added a commit that referenced this pull request Jan 10, 2023
…17926)" (#18617)

* Revert "Add mount path into the default generated openapi.json spec (UI) (#17926)"

This reverts commit db8efac.

* Revert "Remove `generic_mount_paths` field (#18558)"

This reverts commit 79c8f62.
AnPucel pushed a commit that referenced this pull request Jan 14, 2023
PR #17926 already deleted the implementation of the
`generic_mount_paths` field so it needs to be removed from the declared
fields of the path too, so help and OpenAPI isn't misleading.
AnPucel pushed a commit that referenced this pull request Jan 14, 2023
…17926)" (#18617)

* Revert "Add mount path into the default generated openapi.json spec (UI) (#17926)"

This reverts commit db8efac.

* Revert "Remove `generic_mount_paths` field (#18558)"

This reverts commit 79c8f62.
AnPucel pushed a commit that referenced this pull request Feb 3, 2023
PR #17926 already deleted the implementation of the
`generic_mount_paths` field so it needs to be removed from the declared
fields of the path too, so help and OpenAPI isn't misleading.
AnPucel pushed a commit that referenced this pull request Feb 3, 2023
…17926)" (#18617)

* Revert "Add mount path into the default generated openapi.json spec (UI) (#17926)"

This reverts commit db8efac.

* Revert "Remove `generic_mount_paths` field (#18558)"

This reverts commit 79c8f62.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants