-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove generic_mount_paths
field
#18558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR hashicorp#17926 already deleted the implementation of the `generic_mount_paths` field so it needs to be removed from the declared fields of the path too, so help and OpenAPI isn't misleading.
Please label |
This is a good catch, thank you for contributing! |
averche
approved these changes
Jan 3, 2023
Thanks for the approval - do I need to do anything more for this to be merged? |
averche
added a commit
that referenced
this pull request
Jan 10, 2023
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #17926 already deleted the implementation of the
generic_mount_paths
field so it needs to be removed from the declaredfields of the path too, so help and OpenAPI isn't misleading.