Sidebar Navigation #19296
Sidebar Navigation #19296
Conversation
* adds hds dependency * updates reset import path * sets minifyCSS advanced option to false
* removes node-sass and fixes sass compilation * fixes active tab li class
* links ember-shared-components addon and imports styles * adds sidebar frame and nav components * updates HcNav component name to HcAppFrame and adds sidebar UserMenu component * adds tests for sidebar components * fixes tests * updates user menu styling * fixes typos in nav cluster component * changes padding value in sidebar stylesheet to use variable
* links ember-shared-components addon and imports styles * adds sidebar frame and nav components * updates activeCluster on auth service and adds activeSession prop for sidebar visibility * replaces old nav components with new ones in templates * fixes sidebar visibility issue and updates user menu label class * removes NavHeader usage * adds clients index route to redirect to dashboard
* removes nav-header components * removes navbar styling * removes status-menu component and styles * removes cluster and auth info components * removes menu-sidebar component and styling * fixes tests
* updates console panel styling * adds test for opening and closing the console panel * updates console panel background color to use hds token * adds right margin to console panel input * updates link-status banner styling
* updates namespace-picker * updates namespace picker menu styling * adds bottom margin to env banner * updates class order on namespace picker link * restores manage namespaces refresh icon * removes manage namespaces nav icon
* adds vault logo to auth page * updates top level error template
… to cluster nav (#20033)
* updates nav components to hds * upgrades project yarn version to 3.5 * fixes issues in app frame component * updates sidenav actions to use icon button component
* adds sidebar navigation acceptance tests and fixes other test failures * console panel styling tweaks
| @cd ui && yarn --ignore-optional | ||
| @cd ui && yarn |
There was a problem hiding this comment.
ignore-optional is no longer supported in yarn 3
| yarn --verbose run build | ||
| yarn run build |
There was a problem hiding this comment.
verbose is also no longer supported
| - [lint-staged\*](https://www.npmjs.com/package/lint-staged) | ||
|
|
||
| \* lint-staged is an optional dependency - running `yarn` will install it. | ||
| If don't want optional dependencies installed you can run `yarn --ignore-optional`. If you've ignored the optional deps | ||
| previously and want to install them, you have to tell yarn to refetch all deps by | ||
| running `yarn --force`. |
There was a problem hiding this comment.
Since this is no longer relevant I decided to remove it entirely but I'm open to replacing it with something different. I'm not sure if it's worth pointing out that it's not required for the build or not?
https://yarnpkg.com/configuration/manifest#optionalDependencies
There was a problem hiding this comment.
I wonder if we should remove the optional dependencies and move them to devDeps (or maybe remove completely? Looks like at least one might have been leftover from when we had storybook).
I'd like to avoid bloating the size of the UI assets with this change, if we can!
There was a problem hiding this comment.
I agree it doesn't seem relevant for us to use the optionalDependencies field anymore. It doesn't look like we use babel-loader and core shouldn't be necessary since we have ember-cli-babel so I will remove those and move lint-staged over to devDependencies.
Adds new sidebar navigation to the UI and removes top nav bar.