Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding gRPC's connection timeout with VAULT_GRPC_MIN_CONNECT_TIMEOUT #19676

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Allow overriding gRPC's connection timeout with VAULT_GRPC_MIN_CONNECT_TIMEOUT #19676

merged 3 commits into from
Mar 22, 2023

Conversation

ncabatoff
Copy link
Contributor

No description provided.

@ncabatoff ncabatoff added this to the 1.13.1 milestone Mar 22, 2023
@ncabatoff ncabatoff enabled auto-merge (squash) March 22, 2023 18:11
jasonodonnell
jasonodonnell approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncabatoff ncabatoff merged commit 0de436b into main Mar 22, 2023
This was referenced Mar 22, 2023
Merged
Merged
Merged
ncabatoff added a commit that referenced this pull request Mar 22, 2023
@ncabatoff
Allow overriding gRPC's connection timeout with VAULT_GRPC_MIN_CONNEC…
e51aa98 
…T_TIMEOUT (#19676)
ncabatoff added a commit that referenced this pull request Mar 22, 2023
@ncabatoff
Allow overriding gRPC's connection timeout with VAULT_GRPC_MIN_CONNEC…
094fae1 
…T_TIMEOUT (#19676)
ncabatoff pushed a commit that referenced this pull request Mar 23, 2023
@hc-github-team-secure-vault-core
Backport of Allow overriding gRPC's connection timeout with VAULT_GRP…
63a1d8d 
…C_MIN_CONNECT_TIMEOUT into release/1.12.x (#19679)

* Allow overriding gRPC's connection timeout with VAULT_GRPC_MIN_CONNECT_TIMEOUT (#19676)
* Include change from #19701.
ncabatoff pushed a commit that referenced this pull request Mar 23, 2023
@hc-github-team-secure-vault-core
Backport of Allow overriding gRPC's connection timeout with VAULT_GRP…
947beba 
…C_MIN_CONNECT_TIMEOUT into release/1.11.x (#19678)

* Allow overriding gRPC's connection timeout with VAULT_GRPC_MIN_CONNECT_TIMEOUT (#19676)
* Include change from #19701.
@jasonodonnell jasonodonnell deleted the add-grpc-min-connect-timeout-override branch April 21, 2023 13:42
ncabatoff added a commit that referenced this pull request May 29, 2023
@ncabatoff
Revert #19676, we decided this was unnecessary.
f9ebda7
ncabatoff added a commit that referenced this pull request May 29, 2023
@ncabatoff
Revert #19676, we decided this was unnecessary. (#20826)
c672424
ncabatoff added a commit that referenced this pull request May 29, 2023
@ncabatoff
Revert #19676, we decided this was unnecessary. (#20826)
a544c2b
ncabatoff added a commit that referenced this pull request May 29, 2023
@ncabatoff
Revert #19676, we decided this was unnecessary. (#20826)
8d66586
ncabatoff added a commit that referenced this pull request May 29, 2023
@ncabatoff
Revert #19676, we decided this was unnecessary. (#20826)
e285e78
ncabatoff added a commit that referenced this pull request May 30, 2023
@ncabatoff
Revert #19676, we decided this was unnecessary. (#20826) (#20832)
c4d9259
ncabatoff added a commit that referenced this pull request May 30, 2023
@ncabatoff
Revert #19676, we decided this was unnecessary. (#20826) (#20831)
94f91eb
ncabatoff added a commit that referenced this pull request May 31, 2023
@ncabatoff
Revert #19676, we decided this was unnecessary. (#20826) (#20833)
7fb4bbf
@fopina-ci fopina-ci mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ncabatoff @jasonodonnell