Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Critical Vulnerabilities from Dependencies #19901

Merged
merged 5 commits into from
Apr 3, 2023
Merged

Address Critical Vulnerabilities from Dependencies #19901

merged 5 commits into from
Apr 3, 2023

Conversation

zofskeez
Copy link
Contributor

Running yarn audit --groups dependencies was returning critical vulnerabilities from handlebars, js-yaml and lodash dependencies. It doesn't look like js-yaml and lodash are used anymore so I removed them and bumped handlebars to the latest version. I also removed some resolutions and updated node to >=16. Running the audit command after returns 0 vulnerabilities.

@zofskeez zofskeez added the ui label Mar 31, 2023
@zofskeez zofskeez added this to the 1.14 milestone Mar 31, 2023
hashishaw
hashishaw approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@zofskeez zofskeez requested a review from a team as a code owner March 31, 2023 20:05
marcboudreau
marcboudreau approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@marcboudreau marcboudreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub Actions workflow changes look good to me.

@zofskeez zofskeez merged commit 439a16a into main Apr 3, 2023
@zofskeez zofskeez deleted the ui/VAULT-8437/critical-dep-warning-cleanup branch April 3, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashishaw hashishaw hashishaw approved these changes

@marcboudreau marcboudreau marcboudreau approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@zofskeez @marcboudreau @hashishaw