Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor follow-ups to #16865 #20220

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Minor follow-ups to #16865 #20220

merged 2 commits into from
Apr 18, 2023

Conversation

maxb
Copy link
Contributor

@maxb maxb commented Apr 18, 2023

Fix PKI issuer upgrade logic when upgrading to 1.12 or later, to
actually turn off the issuer crl-signing usage when it intended to.

Fix minor typo in docs.

Closes #20189

Fix PKI issuer upgrade logic when upgrading to 1.12 or later, to
actually turn off the issuer crl-signing usage when it intended to.

Fix minor typo in docs.
@maxb maxb requested a review from a team April 18, 2023 10:18
@maxb
Copy link
Contributor Author

maxb commented Apr 18, 2023

Backport to 1.12 and 1.13 suggested. Not applicable for 1.11.

Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @maxb!

@cipherboy cipherboy added this to the 1.14 milestone Apr 18, 2023
@cipherboy cipherboy added the bug Used to indicate a potential bug label Apr 18, 2023
@cipherboy cipherboy merged commit acfc862 into hashicorp:main Apr 18, 2023
stevendpclark pushed a commit that referenced this pull request Apr 18, 2023
* Minor follow-ups to #16865

Fix PKI issuer upgrade logic when upgrading to 1.12 or later, to
actually turn off the issuer crl-signing usage when it intended to.

Fix minor typo in docs.

* changelog
stevendpclark pushed a commit that referenced this pull request Apr 18, 2023
* Minor follow-ups to #16865

Fix PKI issuer upgrade logic when upgrading to 1.12 or later, to
actually turn off the issuer crl-signing usage when it intended to.

Fix minor typo in docs.

* changelog
stevendpclark pushed a commit that referenced this pull request Apr 18, 2023
* Minor follow-ups to #16865

Fix PKI issuer upgrade logic when upgrading to 1.12 or later, to
actually turn off the issuer crl-signing usage when it intended to.

Fix minor typo in docs.

* changelog

Co-authored-by: Max Bowsher <maxbowsher@gmail.com>
stevendpclark pushed a commit that referenced this pull request Apr 18, 2023
* Minor follow-ups to #16865

Fix PKI issuer upgrade logic when upgrading to 1.12 or later, to
actually turn off the issuer crl-signing usage when it intended to.

Fix minor typo in docs.

* changelog

Co-authored-by: Max Bowsher <maxbowsher@gmail.com>
@maxb maxb deleted the fix20189 branch June 1, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug secret/pki
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coding error in PKI issuer upgrade re CRL issuance
3 participants