Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve addPrefixToKVPath helper #20488

Merged
merged 4 commits into from
May 3, 2023
Merged

Improve addPrefixToKVPath helper #20488

merged 4 commits into from
May 3, 2023

Conversation

averche
Copy link
Contributor

@averche averche commented May 3, 2023 •
edited
Loading

Improving the functionality of the existing addPrefixToKVPath CLI helper. It will allow to optionally skip the prefix if it already exists in the path, which is required for the vault agent generate-config functionality.

This change does not affect any of the existing code, since skipIfExists is set to false for all calls to addPrefixToKVPath.

@averche averche requested a review from a team May 3, 2023 16:38
@averche averche added this to the 1.14 milestone May 3, 2023
lursu
lursu approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@lursu lursu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dhuckins
dhuckins approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@dhuckins dhuckins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of the calls are false for the last param, eventually that will be used?

@averche
Copy link
Contributor Author

averche commented May 3, 2023

all of the calls are false for the last param, eventually that will be used?

Yes, I'll be using it for the generate-config logic.

@averche averche enabled auto-merge (squash) May 3, 2023 16:54
@averche averche merged commit 06bc130 into main May 3, 2023
@averche averche deleted the add-prefix-helper branch May 3, 2023 17:12
hellobontempo pushed a commit that referenced this pull request May 3, 2023
@averche @hellobontempo
Improve addPrefixToKVPath helper (#20488)
cb5162d
@averche averche mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhuckins dhuckins dhuckins approved these changes

@lursu lursu lursu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@averche @lursu @dhuckins