Keep symbols by default #20519
Merged
Keep symbols by default #20519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By reversing the logic and adding a `REMOVE_SYMBOLS` environment variable that, when set, will remove symbols. This has been requested to re-enable Dynatrace support, which requires symbols are intact. Sadly this increases the size (on my mac) from 192,609,682 bytes to 236,696,722 bytes (+23% increase). I confirmed that this adds symbols back, and that `dlv` will load the Vault binary.
cipherboy
approved these changes
May 4, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By reversing the logic and adding a
REMOVE_SYMBOLSenvironment variable that, when set, will remove symbols.This has been requested to re-enable Dynatrace support, which requires symbols are intact.
Sadly this increases the size (on my mac) from 192,609,682 bytes to 236,696,722 bytes (+23% increase).
I confirmed that this adds symbols back, and that
dlvwill load the Vault binary.