Backport of Fix: non-login requests shouldn't care about login roles for lease quotas. Also fix a potential deadlock into release/1.12.x #21186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/enable-auth-mount-lock-deadlock-detection/terminally-wise-dassie
branch
from
c1e61c2
to
c33bfd6
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/enable-auth-mount-lock-deadlock-detection/terminally-wise-dassie
branch
from
54e4518
to
c26bb9b
Compare
VioletHynes
added
the
hashicorp-contributed-pr
schavis
added
the
vault-update
…adlock-detection/terminally-wise-dassie
|
CI Results: |
|
Build Results: |
ncabatoff
approved these changes
Aug 18, 2023
ncabatoff
deleted the
backport/enable-auth-mount-lock-deadlock-detection/terminally-wise-dassie
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21110 to be assessed for backporting due to the inclusion of the label backport/1.12.x.
The below text is copied from the body of the original PR.
I'm working on some code in ent that messes with how we use these locks, so I turned on deadlock detection, and I found a pre-existing issue. Creating this PR to highlight it.
Overview of commits