VAULT-17772: bump go-eventlogger to v0.2.1 #21623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version of go-eventlogger to
v0.2.1
, which provides the ability to remove nodes when removing a pipeline, previously we didn't remove nodes and risked slowly leaking memory as web-sockets subscribed => unsubscribed from the eventbus.Some logic has been added to handle logging depending on whether:
Small other changes:
NewBroker
returns an error paramClose
now requirescontext
The bump to
v0.2.1
is required as we move audit to use eventlogger too and will need to clear up nodes and pipelines.