Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-17772: bump go-eventlogger to v0.2.1 #21623

Merged
merged 9 commits into from
Jul 6, 2023

Conversation

peteski22
Copy link

@peteski22 peteski22 commented Jul 6, 2023

This PR updates the version of go-eventlogger to v0.2.1, which provides the ability to remove nodes when removing a pipeline, previously we didn't remove nodes and risked slowly leaking memory as web-sockets subscribed => unsubscribed from the eventbus.

Some logic has been added to handle logging depending on whether:

  1. Pipeline was removed but there was an error removing the referenced nodes.
  2. Pipeline was not removed (and therefore referenced nodes remain too).

Small other changes:

  • NewBroker returns an error param
  • Close now requires context

The bump to v0.2.1 is required as we move audit to use eventlogger too and will need to clear up nodes and pipelines.

@peteski22 peteski22 marked this pull request as ready for review July 6, 2023 16:16
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for this work in go-eventlogger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants