UI: Allow navigate to list from View Secret card #22502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
|
||
| get buttonText() { | ||
| if (this.args.type === 'secret') { | ||
| if (this.secret.endsWith('/')) { |
There was a problem hiding this comment.
I didn't know endsWith() was a thing!! So cool 🤩
|
Build Results: |
|
CI Results: |
hellobontempo
approved these changes
Aug 23, 2023
This was referenced Aug 23, 2023
hashishaw
added a commit
that referenced
this pull request
Aug 23, 2023
hashishaw
added a commit
that referenced
this pull request
Aug 23, 2023
|
Can only backport as far as 1.13 because the base changes in |
This was referenced Aug 23, 2023
hashishaw
added a commit
that referenced
this pull request
Aug 23, 2023
hashishaw
added a commit
that referenced
this pull request
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the View Secret card that shows when no
LISTpermissions on a KV engine would only navigate to the show secret page.With this update, if the input ends in a slash the button will update to say "View list" and it will take you to the correct subdirectory in KV:
I also changed the way the form is triggered, so that it will trigger both on button click and "Enter" key (like a normal form)
Fixes #20563