Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Limiter listener config opt-out #25098

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

mpalmi
Copy link
Contributor

@mpalmi mpalmi commented Jan 26, 2024

This new nice-to-have configuration should allow operators to opt out of Request Limiting on a per-listener basis.

This PR builds on top of #25093.

The config allows Vault to remain protected in break-glass scenarios, providing a means to turn off the request limiter for specific tasks. We can encourage users to bypass the limiter for specific actions, rather than shutting it all off.

I've done some manual verification and dev-testing.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 26, 2024
@mpalmi mpalmi changed the title Add listener config opt-out for Request Limiter Request Limiter listener config opt-out Jan 26, 2024
@mpalmi mpalmi marked this pull request as ready for review January 26, 2024 17:59
@mpalmi mpalmi marked this pull request as draft January 26, 2024 18:00
@mpalmi mpalmi requested review from raskchanky and a team January 26, 2024 18:01
Copy link

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Jan 26, 2024

CI Results:
Failures:

Test Type Package Test Logs
race physical/raft TestFSM_Chunking_TermChange view test results
race physical/raft TestRaft_Backend view test results
race physical/raft TestRaft_Backend/use_wal view test results
race physical/raft TestRaft_Backend_LargeKey view test results
race physical/raft TestRaft_Backend_LargeKey/use_wal view test results
race physical/raft TestRaft_Backend_LargeValue view test results
race physical/raft TestRaft_Backend_LargeValue/use_wal view test results
race physical/raft TestRaft_Backend_ListPrefix view test results
race physical/raft TestRaft_Backend_ListPrefix/use_wal view test results
race physical/raft TestRaft_Backend_Performance view test results

and 29 other tests

@mpalmi mpalmi added this to the 1.16.0-rc1 milestone Jan 26, 2024
Base automatically changed from request-limiter to main January 26, 2024 19:26
@mpalmi mpalmi closed this Jan 26, 2024
@mpalmi mpalmi force-pushed the request-limiter-optout-listener-config branch from 723f9d8 to 43be9fc Compare January 26, 2024 19:35
@mpalmi mpalmi removed this from the 1.16.0-rc1 milestone Jan 26, 2024
@mpalmi mpalmi deleted the request-limiter-optout-listener-config branch January 26, 2024 19:39
@mpalmi mpalmi restored the request-limiter-optout-listener-config branch January 26, 2024 19:51
@mpalmi mpalmi reopened this Jan 26, 2024
@mpalmi mpalmi marked this pull request as ready for review January 26, 2024 19:57
@mpalmi mpalmi added this to the 1.16.0-rc1 milestone Jan 26, 2024
@mpalmi mpalmi force-pushed the request-limiter-optout-listener-config branch from eb49e09 to 273465a Compare January 26, 2024 20:02
Copy link
Contributor

@raskchanky raskchanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpalmi mpalmi merged commit 12f69a8 into main Jan 26, 2024
109 of 110 checks passed
@mpalmi mpalmi deleted the request-limiter-optout-listener-config branch January 26, 2024 20:24
Monkeychip pushed a commit that referenced this pull request Jan 29, 2024
This commit introduces a new listener config option to allow disabling the request limiter per-listener.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants