-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request Limiter listener config opt-out #25098
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Jan 26, 2024
mpalmi
changed the title
Add listener config opt-out for Request Limiter
Request Limiter listener config opt-out
Jan 26, 2024
Build Results: |
CI Results:
and 29 other tests |
mpalmi
force-pushed
the
request-limiter-optout-listener-config
branch
from
January 26, 2024 19:35
723f9d8
to
43be9fc
Compare
mpalmi
force-pushed
the
request-limiter-optout-listener-config
branch
from
January 26, 2024 20:02
eb49e09
to
273465a
Compare
raskchanky
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Monkeychip
pushed a commit
that referenced
this pull request
Jan 29, 2024
This commit introduces a new listener config option to allow disabling the request limiter per-listener.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new nice-to-have configuration should allow operators to opt out of Request Limiting on a per-listener basis.
This PR builds on top of #25093.
The config allows Vault to remain protected in break-glass scenarios, providing a means to turn off the request limiter for specific tasks. We can encourage users to bypass the limiter for specific actions, rather than shutting it all off.
I've done some manual verification and dev-testing.