identity: skip oidc default key generation on read-only storage error for local mounts #25265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
ncabatoff
reviewed
Feb 7, 2024
|
CI Results:
|
|
Build Results: |
ncabatoff
reviewed
Feb 7, 2024
austingebauer
changed the title
ncabatoff
approved these changes
Feb 7, 2024
|
Thanks for the fix. For my 2c, that edge case is obscure enough and we can detect it well enough to simply tell the user they need to go and do something on the primary cluster before they can continue. Ideally it would be nice to have a dedicated endpoint to tell them to hit for that purpose so that they can do something with no additional side effects. |
Monkeychip
pushed a commit
that referenced
this pull request
Feb 12, 2024
… for local mounts (#25265) * identity: skip oidc default key generation on read-only storage error * fix logic error * only log warning if local mount * handle ErrReadOnly immediately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes enterprise tests that were encountering read-only storage errors for local-only mounts. The local-only mounts were trying to generate the OIDC default key which involves a storage write. We will simply log a warning and allow the local-only mount to be created for now.
This approach has an edge case where plugin workload identity would not work if:
I'm going to think on a better solution for this. In the meantime, this PR fixes the tests.