Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address cert auth error message logic error #27202

Merged
merged 1 commit into from
May 24, 2024
Merged

Address cert auth error message logic error #27202

merged 1 commit into from
May 24, 2024

Conversation

stevendpclark
Copy link
Contributor

  • Cert auth had a logic error when crafting the error response when configured with a leaf certificate to validate against. It would generate an error response that used a nil error.
  • Make the cert auth error messages the same when we fail to match constraints

@stevendpclark
Address cert auth error message logic error
1a28208 
 - Cert auth had a logic error when crafting the error response when
   configured with a leaf certificate to validate against. It would
   generate an error response that used a nil error.
 - Make the cert auth error messages the same when we fail to match
   constraints
@stevendpclark stevendpclark added the auth/cert Authentication - certificates label May 23, 2024
@stevendpclark stevendpclark added this to the 1.18.0-rc milestone May 23, 2024
@stevendpclark stevendpclark self-assigned this May 23, 2024
@stevendpclark stevendpclark requested a review from a team as a code owner May 23, 2024 17:16
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 23, 2024
@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

victorr
victorr approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stevendpclark stevendpclark merged commit 2c3b41c into main May 24, 2024
89 checks passed
@stevendpclark stevendpclark deleted the stevendpclark/vault-27483-cert-auth-error branch May 24, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorr victorr victorr approved these changes

Assignees

@stevendpclark stevendpclark

Labels
auth/cert Authentication - certificates hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.18.0-rc
Development

Successfully merging this pull request may close these issues.
2 participants
@stevendpclark @victorr