Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: fix export button tests #27945

Merged
merged 2 commits into from
Aug 1, 2024
Merged

UI: fix export button tests #27945

merged 2 commits into from
Aug 1, 2024

Conversation

hashishaw
Copy link
Contributor

Description

After merging some updates to client count exporting, the export-button test started to fail in enterprise CI only. This is an attempt to resolve those failures, or at least make them easier to parse instead of the non-helpful:

[vault]         actual: >
[vault]             [object Object]
[vault]         expected: >
[vault]             [object Object]

@hashishaw hashishaw added this to the 1.18.0-rc milestone Aug 1, 2024
@hashishaw hashishaw requested a review from a team as a code owner August 1, 2024 18:29
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Build Results:
All builds succeeded! ✅

Monkeychip
Monkeychip approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

CI Results:
All Go tests succeeded! ✅

@hashishaw hashishaw merged commit 68a5741 into main Aug 1, 2024
43 checks passed
@hashishaw hashishaw deleted the ui/fix-export-button-tests branch August 1, 2024 18:55
Monkeychip pushed a commit that referenced this pull request Aug 1, 2024
@hashishaw @Monkeychip
UI: fix export button tests (#27945)
778b677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Milestone
1.18.0-rc
Development

Successfully merging this pull request may close these issues.
2 participants
@hashishaw @Monkeychip