-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hana db pkg #27950
Merged
Merged
Update hana db pkg #27950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Aug 2, 2024
CI Results: |
Build Results: |
fairclothjm
approved these changes
Aug 5, 2024
tvoran
commented
Aug 5, 2024
@@ -51,7 +51,7 @@ more information about setting up the database secrets engine. | |||
```text | |||
$ vault write database/roles/my-role \ | |||
db_name=my-hana-database \ | |||
creation_statements="CREATE USER {{name}} PASSWORD {{password}} VALID UNTIL '{{expiration}}';\ | |||
creation_statements="CREATE USER {{name}} PASSWORD \"{{password}}\" VALID UNTIL '{{expiration}}';\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to account for generated passwords having -
's in them.
Thanks! |
akshya96
pushed a commit
that referenced
this pull request
Aug 7, 2024
* database/hana: use go-hdb v1.10.1 * docs/hana: quotes around password so dashes don't break it
akshya96
added a commit
that referenced
this pull request
Aug 20, 2024
* auto-roll billing start enos test * enos: don't expect curl available in docker image (#27984) Signed-off-by: Ryan Cragun <me@ryan.ec> * Update interoperability-matrix.mdx (#27977) Updating the existing Vault/YubiHSM integration with a newer version of Vault as well as now supporting Managed Keys. * Update hana db pkg (#27950) * database/hana: use go-hdb v1.10.1 * docs/hana: quotes around password so dashes don't break it * Clarify audit log failure telemetry docs. (#27969) * Clarify audit log failure telemetry docs. * Add the note about the misleading counts * Auto-rolling billing start docs PR (#27926) * auto-roll docs changes * addressing comments * address comments * Update website/content/api-docs/system/internal-counters.mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> * addressing some changes * update docs * update docs with common explanation file * updated note info * fix 1.18 upgrade doc * fix content-check error * Update website/content/partials/auto-roll-billing-start-example.mdx Co-authored-by: miagilepner <mia.epner@hashicorp.com> --------- Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> Co-authored-by: miagilepner <mia.epner@hashicorp.com> * docker: add upgrade notes for curl removal (#27995) Signed-off-by: Ryan Cragun <me@ryan.ec> * Update vault-plugin-auth-jwt to v0.21.1 (#27992) * docs: fix upgrade 1.16.x (#27999) Signed-off-by: Ryan Cragun <me@ryan.ec> * UI: Add unsupportedCriticalCertExtensions to jwt config expected payload (#27996) * Client Count Docs Updates/Cleanup (#27862) * Docs changes * More condensation of docs * Added some clarity on date ranges * Edited wording' * Added estimation client count info * Update website/content/api-docs/system/internal-counters.mdx Co-authored-by: miagilepner <mia.epner@hashicorp.com> --------- Co-authored-by: miagilepner <mia.epner@hashicorp.com> * update(kubernetes.mdx): k8s-tokenreview URL (#27993) Co-authored-by: akshya96 <87045294+akshya96@users.noreply.github.com> * Update programmatic-management.mdx to clarify Terraform prereqs (#27548) * UI: Replace getNewModel with hydrateModel when model exists (#27978) * Replace getNewModel with hydrateModel when model exists * Update getNewModel to only handle nonexistant model types * Update test * clarify test * Fix auth-config models which need hydration not generation * rename file to match service name * cleanup + tests * Add comment about helpUrl method * Changelog for 1.17.3, 1.16.7 enterprise, 1.15.13 enterprise (#28018) * changelog for 1.17.3, 1.16.7 enterprise, 1.15.13 enterprise * Add spacing to match older changelogs * Fix typo in variables.tf (#27693) intialize -> initialize Co-authored-by: akshya96 <87045294+akshya96@users.noreply.github.com> * Update 1_15-auto-upgrade.mdx (#27675) * Update 1_15-auto-upgrade.mdx * Update known issue version numbers for AP issue --------- Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> * Update 1_16-default-policy-needs-to-be-updated.mdx (#27157) Made a few grammar changes plus updating term from Vault IU to Vault UI * change instances variable to hosts * for each hosts * add cluster addr port * Add ENVs using NewTestDockerCluster (#27457) * Add ENVs using NewTestDockerCluster Currently NewTestDockerCluster had no means for setting any environment variables. This makes it tricky to create test for functionality that require thems, like having to set AWS environment variables. DockerClusterOptions now exposes an option to pass extra enviroment variables to the containers, which are appended to the existing ones. * adding changelog * added test case for setting env variables to containers * fix changelog typo; env name * Update changelog/27457.txt Co-authored-by: akshya96 <87045294+akshya96@users.noreply.github.com> * adding the missing copyright --------- Co-authored-by: akshya96 <87045294+akshya96@users.noreply.github.com> * UI: Build KV v2 overview page (#28106) * move date-from-now helper to addon * make overview cards consistent across engines * make kv-paths-card component * remove overview margin all together * small styling changes for paths card * small selector additions * add overview card test * add overview page and test * add default timestamp format * cleanup paths test * fix dateFromNow import * fix selectors, cleanup pki selectors * and more selector cleanup * make deactivated state single arg * fix template and remove @isDeleted and @isDestroyed * add test and hide badge unless deactivated * address failings from changing selectors * oops, not ready to show overview tab just yet! * add deletionTime to currentSecret metadata getter * Bump actions/download-artifact from 4.1.7 to 4.1.8 (#27704) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.7 to 4.1.8. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@65a9edc...fa0a91b) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: akshya96 <87045294+akshya96@users.noreply.github.com> * Bump actions/setup-node from 4.0.2 to 4.0.3 (#27738) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@60edb5d...1e60f62) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: akshya96 <87045294+akshya96@users.noreply.github.com> * Add valid IP callout (#28112) Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com> * Refactor SSH Configuration workflow (#28122) * initial copy from other #28004 * pr feedback * grr * Bump browser-actions/setup-chrome from 1.7.1 to 1.7.2 (#28101) Bumps [browser-actions/setup-chrome](https://github.com/browser-actions/setup-chrome) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/browser-actions/setup-chrome/releases) - [Changelog](https://github.com/browser-actions/setup-chrome/blob/master/CHANGELOG.md) - [Commits](browser-actions/setup-chrome@db1b524...facf10a) --- updated-dependencies: - dependency-name: browser-actions/setup-chrome dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: divyaac <divya.chandrasekaran@hashicorp.com> * Bump vault-gcp-secrets-plugin (#28089) Co-authored-by: divyaac <divya.chandrasekaran@hashicorp.com> * docs: correct list syntax (#28119) Co-authored-by: divyaac <divya.chandrasekaran@hashicorp.com> * add semgrepconstraint check in skip step --------- Signed-off-by: Ryan Cragun <me@ryan.ec> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ryan Cragun <me@ryan.ec> Co-authored-by: Adam Rowan <92474478+bear359@users.noreply.github.com> Co-authored-by: Theron Voran <tvoran@users.noreply.github.com> Co-authored-by: Paul Banks <pbanks@hashicorp.com> Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> Co-authored-by: miagilepner <mia.epner@hashicorp.com> Co-authored-by: Scott Miller <smiller@hashicorp.com> Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com> Co-authored-by: divyaac <divya.chandrasekaran@hashicorp.com> Co-authored-by: Roman O'Brien <58272664+romanobrien@users.noreply.github.com> Co-authored-by: Adrian Todorov <adrian.todorov@hashicorp.com> Co-authored-by: VAL <val@hashicorp.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Owen Zhang <86668876+owenzorrin@users.noreply.github.com> Co-authored-by: gkoutsou <gkoutsou@users.noreply.github.com> Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com> Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com> Co-authored-by: Angel Garbarino <Monkeychip@users.noreply.github.com> Co-authored-by: Max Levine <max@maxlevine.co.uk> Co-authored-by: Steffy Fort <steffyfort@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the HANA db package to v1.10.1.
Closes #27588
Tested against HANA express edition:
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+ent
labelsinstead of the old style
backport/x.x.x
labels.the normal
backport/x.x.x
label (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.