Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-sdk-go deps #4743

Closed
wants to merge 1 commit into from
Closed

Update aws-sdk-go deps #4743

wants to merge 1 commit into from

Conversation

kalafut
Copy link
Contributor

@kalafut kalafut commented Jun 12, 2018

Fixes #4721
Fixes #4742

@kalafut kalafut added this to the 0.10.3 milestone Jun 12, 2018
@kalafut kalafut requested a review from jefferai June 12, 2018 00:03
@jefferai
Copy link
Member

Watch this break something else. But, gotta do what we gotta do, unless we want to update just that package.

@kalafut
Copy link
Contributor Author

kalafut commented Jun 12, 2018

Yeah it’s a lot of changes. I guess we have to consume it at some point, but maybe the big update can be done right after we stabilize 0.10.3 (or so) to maximize the time on it. I can rework to just get the one change in instead.

@jefferai
Copy link
Member

Up to you -- I'd look at the surface of the change (if it's just your fixes, vs. a lot of others) because sometimes they have a lot of intermingled changes. If it's just yours though, might be worth cherry-picking and save the big update for post-0.10.3.

@kalafut
Copy link
Contributor Author

kalafut commented Jun 12, 2018

I'm not comfortable taking in almost 70 changed files with just a few days testing. Fortunately, govendor fetch of just the affected package brings in only my change so there should be no cherry-picking required, nor broken coupling.

See PR #4744.

@kalafut kalafut closed this Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants