Trash: multiple properties

[michaelherold]

API 2.0.
Described 2 properties for Trash. The only last one is assigned.

class DateViewModel < Hashie::Trash
  property :month, from: :date, with: lambda { |date| raise date.month.inspect; date.month }
  property :year, from: :date, with: lambda { |date| date.strftime('%Y') }                                                                          
end

DateViewModel.new(date: Date.new) 
#=> <DateViewModel year="2012">

Only :year is assigned.
Expected :month to be assigned as well.
Lambda for first property :month is not executed.

[jch]

Sounds interesting. Would you be interested in creating a pull request for it?

[dblock]

This has been fixed in HEAD.

[klaustopher]

Sure this is fixed? I just ran into this issue

>> Hashie::VERSION
=> "3.2.0"

>> class SomeDataModel < Hashie::Trash
>>   property :value_a, from: :config, with: ->(config) { config.a }
>>   property :value_b, from: :config, with: ->(config) { config.b }
>>   end

>> dm = SomeDataModel.new(config: OpenStruct.new(a: 'A VALUE', b: 'B VALUE'))
=> #<SomeDataModel value_b="B VALUE">

>> dm.value_a
=> nil

>> dm.value_b
=> "B VALUE"

[dblock]

Can you write a test please for this in a PR? I'll reopen for now.

[michaelherold]

I've confirmed that this is a current bug. The problem is that the from parameter is redefined each time it occurs, via the lines at trash.rb:31 through trash.rb:34. If you run pry just before that
block and run just the test at trash_spec:147, you'll see that the #config= method is defined once for value_a and once for value_b, thus overwriting the fetcher for value_a.

I can tell what the bug is, but I'm having trouble wrapping my brain around how to fix it. I went through and bisected the area of interest. einzige fixed the issue in 9a38985, but that fix apparently broke the case in trash_spec.rb:31, so artm fixed it in 44d1416.

[dblock]

I PRed basically the same fix as in 9a38985.