Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempus 965-Template registry #1009

Merged
merged 14 commits into from
Jan 16, 2019
Merged

Tempus 965-Template registry #1009

merged 14 commits into from
Jan 16, 2019

Conversation

Shobhit2884
Copy link
Contributor

@Shobhit2884 Shobhit2884 commented Jan 15, 2019

This PR contains the functionality for Template registry including the ADD/EDIT/DELETE/COPY functionality with grid and tabular view.

In order to streamline the review of the contribution please
ensure the following steps have been taken:

For all changes:

  • Is there a Waffle ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with Tempus-XXXX where XXXX is the waffle number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically dev)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root Tempus folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • Have you added documentation for any UI or API related changes to the /docs folder

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2019

CLA assistant check
All committers have signed the CLA.

@NandiniMGawade
Copy link
Contributor

Remove lazy-load-data.directive.js

@NandiniMGawade
Copy link
Contributor

LGTM

Copy link
Contributor

@akshaymhetre akshaymhetre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add 'templates' table in drop-tables file

@Shobhit2884 Shobhit2884 force-pushed the Tempus-965 branch 2 times, most recently from be92f6c to 8d4de23 Compare January 16, 2019 11:38
@Shobhit2884 Shobhit2884 merged commit d8d3892 into dev Jan 16, 2019
@Shobhit2884 Shobhit2884 deleted the Tempus-965 branch January 16, 2019 12:38
@shgupta22 shgupta22 restored the Tempus-965 branch January 17, 2019 08:04
@shgupta22 shgupta22 deleted the Tempus-965 branch January 29, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants