Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempus 919 kv entry with unit #958

Merged
merged 15 commits into from
Jan 2, 2019
Merged

Tempus 919 kv entry with unit #958

merged 15 commits into from
Jan 2, 2019

Conversation

shgupta22
Copy link
Contributor

@shgupta22 shgupta22 commented Dec 24, 2018

User Story: #919

PR contains the following:

  1. Schema changes for TS, DS and Attribute tables
  2. Model and Entity changes for supporting Unit tag with timeseries, depthseries and attributes data.
  3. Doing unit conversion of incoming data before storing in DB. Conversion is done by using the unit-conversion library.
  4. UI changes for displaying units with data.
  5. WebSocket Subscription changes for converting the unit to SI system.
  6. Integration tests for UnitConversion Service and new tests for ts, ds and attribute service with units

Thank you for submitting a contribution to Tempus.

In order to streamline the review of the contribution please
ensure the following steps have been taken:

For all changes:

  • Is there a Waffle ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with Tempus-XXXX where XXXX is the waffle number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically dev)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root Tempus folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • Have you added documentation for any UI or API related changes to the /docs folder

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@anuj-akt anuj-akt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, move unit conversion logic to transport layer.

@shgupta22 shgupta22 merged commit 863aff2 into dev Jan 2, 2019
@shgupta22 shgupta22 deleted the Tempus-919-kvEntry-with-unit branch January 2, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants