Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for maximum amount of agents that should work on a supertask #813

Merged
merged 14 commits into from
Aug 28, 2023

Conversation

gochujang-c
Copy link
Contributor

This is a continuation on #764. The maxAgents configuration for a super task limits the maximum cumulative amount of agents working on on the subtasks.

maxagents

@zyronix zyronix added the new feature New feature to be added label Sep 21, 2022
@zyronix
Copy link
Member

zyronix commented Nov 29, 2022

Fixes #769

@zyronix zyronix linked an issue Jun 13, 2023 that may be closed by this pull request
Copy link
Member

@zyronix zyronix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curl http://127.0.0.1:8080/api/user.php -H "Content-Type: application/json" -X POST -d '{"section": "task", "request": "runPretask", "name": "API test", "hashlistId":1, "pretaskId":1, "crackerVersionId": 1, "accessKey": ""}'
Fails, because a taskwrapper object is not updated.

doc/user-api/sections/task.tex Show resolved Hide resolved
Copy link
Member

@zyronix zyronix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The bulkcreate currently is missing setting the maxAgents. I don't think this is an issue, but just something I noticed.

@s3inlc
Copy link
Member

s3inlc commented Aug 26, 2023

There seems to be an issue when updating the Max Agents value on the Supertasks page. After saving it redirects to the pretasks page and stays there instead of going back to the supertasks page, i.e. the ?super=true does not seem to have the desired effect.

@zyronix
Copy link
Member

zyronix commented Aug 28, 2023

Fixed the broken redirect.

@s3inlc s3inlc merged commit 0e4b833 into hashtopolis:master Aug 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Setting max agents for supertasks
3 participants