Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema creation and end-to-end support #716

Merged
merged 8 commits into from
Oct 7, 2024
Merged

Conversation

LaurentRDC
Copy link
Member

@LaurentRDC LaurentRDC commented Sep 10, 2024

This is a pull request to ensure that we can:

  • Create schemas (CREATE SCHEMA ...) in migrations using createDatabaseSchema;
  • Drop schemas (DROP SCHEMA ...) in migrations using dropDatabaseSchema;
  • Create tables with explicit schemas in migrations using createTableWithSchema;
  • Add support for creating/dropping schemas in beam-postgres;
  • Add tests to ensure that explicit schemas are supported by beam-postgres.

In the course of testing this, I also had to switch beam-postgres's test suite from using tmp-postgres (unmaintained) to testcontainers.

This pull request will remain in draft until I can confirm that these changes are working throughout

@LaurentRDC LaurentRDC marked this pull request as ready for review September 10, 2024 15:31
@LaurentRDC
Copy link
Member Author

LaurentRDC commented Sep 10, 2024

I have tested these changes on our production codebase and everything is working as expected, including migration and a wide variety of queries

@LaurentRDC LaurentRDC linked an issue Sep 10, 2024 that may be closed by this pull request
@LaurentRDC LaurentRDC merged commit 9614ae5 into master Oct 7, 2024
0 of 2 checks passed
@LaurentRDC LaurentRDC removed the request for review from kmicklas October 7, 2024 17:11
@LaurentRDC LaurentRDC deleted the end-to-end-schema-support branch October 9, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Postgres schemas
1 participant