This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
Tests receive events eagerly #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for this change: it should not be assumed that events at an EndPoint will be queued without bound. That's to say, it should not be assumed that an action which induces an event at an EndPoint will not block if the previous event has not been pulled out by receive.
avieth
force-pushed
the
avieth/avoid_blocking
branch
from
655a673
to
e5bb29a
Compare
|
LGTM |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this change: it should not be assumed that events at
an EndPoint will be queued without bound. That's to say, it should not
be assumed that an action which induces an event at an EndPoint will not
block if the previous event has not been pulled out by receive.
Related to haskell-distributed/network-transport-tcp#46
With that patch, it's possible to define a
QDiscwhich uses a 1-place queuefor events. It's a perfectly reasonable option, but the tests as they stand will
deadlock because they assume that events will pile up in something like an
unbounded queue.