Fix the front anchor optimization in multiline mode #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #12.
All of the standard test cases pass, and I did some ad-hoc testing at the repl. multiline/singleline modes, new/old syntax, and `/^ all seem to be working correctly together. Let me know if you want me to add them to the test cases formally before you accept the pull request.
It seemed like what happened was that originally tdfa had only both single-line and multi-line modes, with only the "^" anchor. Since in multi-line mode the entire string needed to be scanned for all newlines, the front anchored optimization was disabled in multi-line mode. But when the "`" anchor was added, the logic to set the front-anchor optimization wasn't updated.
Hopefully the code change itself is self-explanatory. Instead of "&&", I pass (multiline co) into isDFAFrontAnchored, and in there if it is in multi-line mode it only treats "`" as an anchor, otherwise, it treats both "`" and "^" as anchors.