Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please, lets fix the origin of lookupEnv #900

Closed
layus opened this issue Mar 23, 2021 · 1 comment · Fixed by #902
Closed

Please, lets fix the origin of lookupEnv #900

layus opened this issue Mar 23, 2021 · 1 comment · Fixed by #902

Comments

@layus
Copy link
Collaborator

layus commented Mar 23, 2021

With #890 and the switch to relude, lookupEnv becomes ill defined.

relude exports lookupEnv but only starting from 1.0.0. As we have no version bounds on relude in hnix.cabal, the build is broken on some configurations.
@layus layus mentioned this issue Mar 23, 2021
Merged
@Anton-Latukha Anton-Latukha mentioned this issue May 6, 2021
Merged
Anton-Latukha added a commit that referenced this issue May 6, 2021
@Anton-Latukha
Merge #922: Updating deps
fe785a1 
* `relude` previous history: #900, #902 & 1.0 changelog: https://hackage.haskell.org/package/relude-1.0.0.1/changelog.

* `base16-bytestring` used only in library.

* `semialign-indexed` deprecated.

* Removed some imports of packages that are not used (at least directly) in executable/tests/bench.

* Added Nixpkgs overrides according to new versions & revision. The same would must be done after HNix release in the Nixpkgs derivation declaration.

etc.
@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented May 7, 2021 •
edited
Loading

relude provides a number of lifted functions/instances, but those relude abilities is to do project-wide decigion of their use and would have a locking effect.
So kept the old origin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limit allowed relude versions layus/hnix
2 participants
@layus @Anton-Latukha