-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed signatures of patchVertices, maxPatchVertices and maxTessellati…
…onLevel. Renamed maxTessellationLevel to maxTessGenLevel.
- Loading branch information
Showing
3 changed files
with
14 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df5dc42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on OpenGL specifications, but aren't all these
GLint
s since the tessellation ARB saysGetIntegerv
forPATCH_VERTICES
andMAX_TESS_GEN_LEVEL
/MAX_PATCH_VERTICES
? (In the Section "New State"/"New Implementation Dependent State")df5dc42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no way to directly retrieve a GLsizei in the OpenGL API, i.e. no glGetSizeiv, only glGetIntegerv. Nevertheless, the state tables (e.g. in the tessellation extension and in chapter 23 "State Tables" of the OpenGL spec itself) distinguish between "Z" (= integer) and "Z+" (= non-negative integer or enumerated value). Put another way: What you retrieve via glGetSizeiv can be a GLint, a, GLsizei, a GLenum, ... The OpenGL API is quite sloppy about typing in general, you have to read the fine print, which means the state table most of the time.
df5dc42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification!