Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

DatatypeContexts is required by Graphics.Rendering.OpenGL.GL.Evaluators #25

Closed
wants to merge 1 commit into from

2 participants

@coreyoconnor

Adds using a LANGUAGE pragma

@dagit
Owner

Hello,

Could you please explain the motivation for this change?

Thanks,
Jason

@coreyoconnor

With GHC 7.2.1 the DataTypeContexts extension was deprecated but was on by default. In GHC 7.4.1 the DataTypeContexts extension is now off by default. This patch re-enables the extension just for that file. Which enables the file to compile under 7.4.1. The change should have no effect on 7.2.1.
A separate patch would be to remove the use of a data type context and use GADTs.

@dagit
Owner
@dagit
Owner

I fixed this by removing the data type context. New version is up on hackage. Thanks for reporting this issue!

@dagit dagit closed this
@coreyoconnor

Excellent! Even better than adding the extension. :-)
I believe data type contexts were deprecated because they had no real effect (Well, not the anticipated effect) So in most cases data type contexts can be removed without issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  Graphics/Rendering/OpenGL/GL/Evaluators.hs
View
1  Graphics/Rendering/OpenGL/GL/Evaluators.hs
@@ -1,3 +1,4 @@
+{-# LANGUAGE DatatypeContexts #-}
--------------------------------------------------------------------------------
-- |
-- Module : Graphics.Rendering.OpenGL.GL.Evaluators
Something went wrong with that request. Please try again.