Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow warp-3.4 #24

Merged
merged 1 commit into from
May 16, 2024
Merged

Allow warp-3.4 #24

merged 1 commit into from
May 16, 2024

Conversation

ysangkok
Copy link
Contributor

Tested using

cabal test --enable-tests -c 'warp>=3.4' -w ghc-9.8.2

@ysangkok ysangkok merged commit 1226da9 into master May 16, 2024
7 checks passed
@ysangkok ysangkok deleted the allow-warp-3.4 branch May 16, 2024 22:45
@ysangkok
Copy link
Contributor Author

@maksbotan Would be good to make this revision too, to make it possible for Stackage to upgrade now that the other Servant packages were revised. Cabal file on Hackage: https://hackage.haskell.org/package/servant-blaze-0.9.1/src/servant-blaze.cabal

@maksbotan
Copy link
Contributor

Done!

Do you know if Stackage will notify us if something is still not building?

@ysangkok
Copy link
Contributor Author

I don't think the Stackage curators are sending out e-mails. And the Servant packages are all marked as owned by a mailing list: Haskell Servant <haskell-servant-maintainers@googlegroups.com>. We could definitely get that changed by submitting a PR to build-constraints.yaml, which is the file that defines who is the owner of each package. I wouldn't want to be responsible for the Servant packages, given I only use it on the side. But there are many people who use it professionally, it would be best for them to sign up.

@ysangkok
Copy link
Contributor Author

Packages can actually be owned by a Github user, which would then receive notifications. That's what I think the Stackage curators prefer to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants