Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt servant-purescript #268

Closed
christian-marie opened this issue Nov 19, 2015 · 22 comments
Closed

Adopt servant-purescript #268

christian-marie opened this issue Nov 19, 2015 · 22 comments
Assignees

Comments

@christian-marie
Copy link
Contributor

@fisx has just made servant-purescript compile with the latest changes: christian-marie/servant-purescript#3

Anchor is no longer using purescript, and most of our original development team there has moved on.

This leads to my question: Do we wish to adopt this repository? I believe it's quite similar to (and based off) servant-js.

I don't think it utilizes servant-foreign yet, though. I haven't checked.

poke: @jkarni, @alpmestan, @soenkehahn, @kosmikus

@fisx
Copy link
Member

fisx commented Nov 19, 2015

actually it does use servant-foreign now. it also generates code that compiles, but there is still open issues (see paf31's comment in the PR, but also remove or update the demos, and a bit more testing, camel-casing instead of flat-casing in some places, small things like that). i could get these out of the way if it helps.

thanks @christian-marie for negotiating this!

@alpmestan
Copy link
Contributor

Sounds good to me, once it's in a good enough shape (what @fisx listed above)! This is great news -- I'm glad servant-purescript is coming back to life.

@christian-marie
Copy link
Contributor Author

Excellent. @fisx, could you please copy this into the servant codebase and do whatever you thought was important? We can then review and decide if it's ready.

@fisx
Copy link
Member

fisx commented Nov 20, 2015

Will do. I'll ping this ticket and the PR over at anchor when I'm ready. Thanks!

@fisx
Copy link
Member

fisx commented Nov 21, 2015

What should I put in here?

author:              Anchor Engineering <engineering@anchor.com.au>
maintainer:          Anchor Engineering <engineering@anchor.com.au>
copyright:           2015 Anchor

@arianvp
Copy link
Member

arianvp commented Nov 21, 2015

You'll have to keep the copyright and author information due to the MIT license afaik. I think you can add your name to it to though. But I am not a lawyer so I hope someone from Anchor can back me on this.

@fisx
Copy link
Member

fisx commented Nov 21, 2015

I don't think MIT license is about the maintainership; we can fill in whoever feels responsible for keeping this in shape. @alpmestan, would that be you? Saw you in the maintainer attribute of servant-js. (-:

@alpmestan
Copy link
Contributor

Well, Maintainer would be whoever ends up taking care of this package. And Author would be Anchor + that person.

@christian-marie
Copy link
Contributor Author

I think that the LICENSE file has to retain Geoffrey's name.

Maintianer could probably be set to the servant team, with the servant mailing list address.

You can certainly add names to the authorship. You can't exactly un-author something, though.

@fizruk
Copy link
Member

fizruk commented Jan 20, 2016

As has been decided on the haskell-servant mailing list, servant-purescript should reside in a separate repo.

@fisx would you be able to move your work from #269 into haskell-servant/servant-purescript or your own repo? Let me know if you need any help with moving things around.

@jkarni
Copy link
Member

jkarni commented Jan 20, 2016

@ctd
Copy link

ctd commented Mar 7, 2016

Hi, is there any progress on this? I note that https://github.com/haskell-servant/servant-purescript is empty right now.

@anchor would like to remove our repo of servant-purescript since we are no longer developing or maintaining this software. We're happy to transfer ownership of our repo if that interests you.

@fisx
Copy link
Member

fisx commented Mar 7, 2016 via email

@ctd
Copy link

ctd commented Mar 7, 2016

@fisx anchor's movement is more related to broader internal changes that mean we aren't actively working with, or on, these projects at present; it has no bearing on the software itself.

@fisx
Copy link
Member

fisx commented Mar 7, 2016

@ctd thanks. that's good to hear.

Perhaps we can move it to the repo that @jkarni created and mark it as 'looking for maintainer', then? I'd be happy to hang around if anybody needs hints. Would that be ok with the servant team?

@alpmestan
Copy link
Contributor

Sounds good to me. We could even publish a little something (blog? mailing list? haskell-cafe@ ? /r/haskell?) to hunt for someone willing to give this package the love it deserves...?

@arianvp
Copy link
Member

arianvp commented Apr 6, 2016

What is our current status on this? Do we want to proceed to 'adopt'? https://github.com/haskell-servant/servant-purescript is still empty at the moment @haskell-servant/maintainers

@soenkehahn
Copy link
Contributor

I'd be in favor of removing the repo, since an empty repo is not very useful. Once someone puts some work into this we can just re-create it.

@soenkehahn
Copy link
Contributor

I'd also be in favor of closing this issue, since interest in this seems to have vanished.

@alpmestan
Copy link
Contributor

Well, either someone volunteers to make this happen, or we remove the repo until someone does, I guess?

@christian-marie
Copy link
Contributor Author

Yep, this should be closed once the https://github.com/haskell-servant/servant repo is removed, or perhaps a README.md is placed there.

@ctd please feel free to transfer the https://github.com/anchor/servant-purescript repo (and any others you wished to retire) to https://github.com/WhereSoftwareGoesToDie, if you were going to destroy it otherwise. I have invited you as an owner.

It would be a shame for this not to be archived "live" somewhere, even if it is defunct.

@soenkehahn
Copy link
Contributor

Since nothing happened since last week I'm going to delete haskell-servant/servant-purescript and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants