Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ALPN #411

Merged
merged 3 commits into from
Dec 29, 2019
Merged

Fixing ALPN #411

merged 3 commits into from
Dec 29, 2019

Conversation

kazu-yamamoto
Copy link
Collaborator

ALPN should be decided before the decision of 0-RTT.

The first commit discloses the bug and the second one should fix it.

@ocheron BTW, do you know which specification requires the rule implemented in checkSessionEquality? I would like to add comments there.

@kazu-yamamoto kazu-yamamoto mentioned this pull request Dec 24, 2019
5 tasks
@ocheron
Copy link
Contributor

ocheron commented Dec 28, 2019

Could you remove liftIO? After moving it's not needed anymore.

@kazu-yamamoto
Copy link
Collaborator Author

Done.

Copy link
Contributor

@ocheron ocheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK thank you

ocheron added a commit that referenced this pull request Dec 29, 2019
@ocheron ocheron merged commit 7455fd8 into haskell-tls:master Dec 29, 2019
@ocheron
Copy link
Contributor

ocheron commented Dec 29, 2019

It seems the rules about session validation are in multiple sections of RFC 8446. Feel free to add better comments in master.

@kazu-yamamoto kazu-yamamoto deleted the fix-alpn branch December 29, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants