Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only alphanum in generated Elm endpoint function names #7

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

rl-king
Copy link
Contributor

@rl-king rl-king commented Oct 17, 2020

Currently generating functions for paths that include - will generate invalid elm function name syntax. This change only allows alpha numeric chars. Which might still be too tolerant, but it filters some of the commonly used symbols in urls.

As I'm writing this I'm wondering if this logic should be part of elm-syntax, any thoughts on that?

@ollef
Copy link
Collaborator

ollef commented Oct 19, 2020

It seems like a good idea to handle that here rather than in elm-syntax IMO.

Thanks!

@ollef ollef merged commit 547f054 into haskell-to-elm:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants