Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note that recommends alternative packages which support HTTPS #106

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Jan 24, 2017

See #105.

@hsenag hsenag merged commit d39e849 into haskell:master Jan 24, 2017
@sjakobi sjakobi deleted the warn-https branch January 24, 2017 20:15
@sjakobi
Copy link
Member Author

sjakobi commented Jan 24, 2017

Thanks! Would you mind making a release (or revision) too, so the warning becomes visible?

@hsenag
Copy link
Member

hsenag commented Jan 25, 2017

Done (along with a suggestion from @hvr), though the markdown doesn't work on hackage so it looks a bit messed up :-( http://hackage.haskell.org/package/HTTP

@hvr
Copy link
Member

hvr commented Jan 25, 2017

@hsenag right... lemme fixup the markup for you... gimme a sec

@hvr
Copy link
Member

hvr commented Jan 25, 2017

@hsenag fixed (mostly -- except for the boldface markup, but that's something that'll be fixed in hackage soonish), see http://hackage.haskell.org/package/HTTP-4000.3.5/revisions/ (and #107)

I totally missed that markdown syntax was used instead of the proper haddock syntax for the links... btw, this is something that uploading as a package candidate is great for (and cabal 2.0 will default to upload as candidate), as there you can preview how the package description will get rendered

hvr added a commit to hvr/HTTP that referenced this pull request Jan 25, 2017
@hvr hvr mentioned this pull request Jan 25, 2017
@hsenag
Copy link
Member

hsenag commented Jan 25, 2017

@hvr: Thanks!

@sjakobi
Copy link
Member Author

sjakobi commented Jan 25, 2017

I totally missed that markdown syntax was used instead of the proper haddock syntax for the links...

Oh, sorry guys. Haddock supports the markdown hyperlink syntax, so I thought that Hackage would support it too… Also thanks for adding the recommendation for http-streams – I wasn't aware of that package!

@hvr
Copy link
Member

hvr commented Jan 25, 2017

@sjakobi I actually forgot that Haddock learned that syntax (albeit it seems imperfect, as it gets confused about the 2nd occurence of the markdown url-ref (i.e. it looks like "http-client (in combination with [http-client-tls](http:/hackage.haskell.orgpackage/http-client-tls) )" when I try the original .cabal revision)

So your expectaction was actually justified; Hackage is supposed to support 99.9% of the markup Haddock supports in .cabal files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants