Cannot install GHC 9.4.3 on windows #129
Comments
|
I get the same failure for 9.2.5. I reported this on the chocolatey repo: https://community.chocolatey.org/packages/ghc#comment-6045114046 |
|
Sounds like it's more than past time for me to add in |
|
@Mistuke Maybe you have a clue what is going wrong here? (NB. I previously commented via chocolatey disqus, but I prefer serious bug trackers. Is https://github.com/Mistuke/GhcChoco/issues a good place to do so?) |
|
@Mistuke: Has anything changed in the way chocolatey installs GHC from 9.4.2 to 9.4.3? I cannot really explain why this would suddenly break on this action's side... |
|
Oh sorry, i missed this ticket. Hmm yes they had deprecated the method I was using to find the install dir so had to use the new install API. Let me take a look |
Yes this is the best place, github comments get through my spam filter always. @andreasabel so the package itself looks fine, I can install it no problem. The issue seems to be that haskell-actions is using an older version of chocolatey. With version 1.2 they deprecated using haskell/actions needs to update the chocolatey package in the image. |
|
@Mistuke: Great, thanks for the analysis and the directions to solve this!
Er, I hate to say, but I am an absolute beginner here. Where would that be located? |
Do you mean the GHA virtual environments?
This should be fine then... |
|
Indeed, but looks like that image was updates just last week https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md but this ticket is a bit older. If it still doesn't work does anyone have a link to an actions log with more info? |
|
In particular a run with |
|
I am now adding this case (GHC 9.4.3 on Windows) to CI. Looks like it is still the same error: |
|
Here is a run with debug printing on: https://github.com/haskell/actions/actions/runs/3796535676/jobs/6456718151 |
|
awesome, thanks, that's very helpful, looks like the new API |
|
ok, managed to reproduce it on my test env. working on a fix |
|
The problem seems to be chocolatey's ill-intentioned approach to removing side-by-side installation support[1]. when using |
|
Pushed: They'll take a few hours to go through automated testing. |
|
@Mistuke: Phantastic! I'll prepare the necessary meta-data additions on the action's side. |
|
@Mistuke: will you apply the same fix to GHC 9.2.5 (which had the same problem as 9.4.3)? |
|
np, sorry for the breakage, I didn't test |
oh, you're right, 9.2.5 uses the new API too. sure let me backport the fix, |
I now know a better place to message you about the choco GHC, as I am not friends with disqus anyway... |
|
Fixed 9.2.5 pushed as 9.2.5.1 - https://community.chocolatey.org/packages/ghc/9.2.5.1 |
|
I'll try the new releases tomorrow (should be ready then). |
|
Cheers, gonna go to bed, let me know how it goes, I tested locally in the sandbox with and without |
|
Good morning! So, 9.4.4 works now, 9.4.3 (and 9.2.5) not yet. The problem is on the action's side. I added some more debug printing to analyse it. In both cases, the chocolatey install of ghc is successful, but then the action succeeds for 9.4.4 and fails for 9.4.3.1: 9.4.4https://github.com/haskell/actions/actions/runs/3799008955/jobs/6461524617#step:3:464 9.4.3.1https://github.com/haskell/actions/actions/runs/3799008955/jobs/6461524713#step:3:468 The difference is caused by the action searching to This suggest the following solution: When resolving |
|
Morning, Hmm this has always been the case though, the |
If I understand correctly, the install location has changed for choco GHC >= 9, so this would explain why it does work for GHC < 9 but breaks here: actions/setup/src/installer.ts Lines 318 to 335 in bc214ec Btw, @maxim-lobanov , you wrote here on 2021-03-08:
As of today, |
|
When you install chocolatey, it registers the following environment variables system wide: So they should be there unless something is clobbering them.. |
|
Yay, CI green! Many thanks @Mistuke for your excellent work! I am intending to release this as 2.1.0, since medium code changes were involved. |
|
@andreasabel yay awesome! Thanks for reporting the failures! |
This adds GHC versions 9.4.4 and 9.4.3 and 9.2.5 (the latter two were blocked by failure on Windows, #129). Fixes #129: - separate out choco revision mechanism (e.g. `9.4.3 -> 9.4.3.1`) from `resolved()` into new `releaseRevision()` - this enables to find `ghc.exe` correctly under `C:\tools\9.4.3` rather than the attempted `C:\tools\9.4.3.1` Further: - secure the problematic versions (7.10.3, 9.2.5, 9.4.3) by CI - verbose chocolatey output in debug mode
This adds GHC versions 9.4.4 and 9.4.3 and 9.2.5 (the latter two were blocked by failure on Windows, haskell#129). Fixes haskell#129: - separate out choco revision mechanism (e.g. `9.4.3 -> 9.4.3.1`) from `resolved()` into new `releaseRevision()` - this enables to find `ghc.exe` correctly under `C:\tools\9.4.3` rather than the attempted `C:\tools\9.4.3.1` Further: - secure the problematic versions (7.10.3, 9.2.5, 9.4.3) by CI - verbose chocolatey output in debug mode
Installing GHC 9.4.3 on Windows fails. 9.4.2 works fine.
Here is the error message:
The text was updated successfully, but these errors were encountered: