Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog: Warn about upcoming breaking changes #220

Merged
merged 3 commits into from
Jul 12, 2020

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented May 11, 2020

One concern that frequently came up in discussions over breaking changes is that many packages currently don't specify an upper bound on bytestring. The note I'm adding here is meant to help remediate that situation.

The planned breaking changes I'm currently aware of are:

and potentially the result of #140.

@sjakobi
Copy link
Member Author

sjakobi commented May 11, 2020

Suggestions to improve the wording of the note are very welcome! :)

@Bodigrim
Copy link
Contributor

It does not hurt, but basically reiterates the fact that major versions bring breaking changes. If some people prefer not to put upper bounds beforehand, I do not think that such warning itself (even if read) will convince them to do otherwise, to be honest.

To be a good citizen, I'd probably try to build a Stackage snapshot, once breaking changes have landed, and report failures to respective maintainers.

@sjakobi
Copy link
Member Author

sjakobi commented May 12, 2020

@Bodigrim bytestring is a bit of a special case in that its last major version bump was 8 years ago! Most Haskell users have probably only ever used some v0.10.*. So I think this reminder could be helpful, even if it won't reach everyone, and not everyone who reads it will act upon it.

Regarding smoke-testing breaking changes, I've inquired about how to do this before, but never actually ended up doing it:

Luckily, once we've released a breaking change, the Stackage maintainers will eventually take of smoke-testing! ;)

Copy link
Contributor

@Bodigrim Bodigrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording looks good to me :)

@Bodigrim Bodigrim mentioned this pull request Jul 2, 2020
@sjakobi sjakobi added this to the 0.10.12.0 milestone Jul 2, 2020
@sjakobi
Copy link
Member Author

sjakobi commented Jul 5, 2020

@hsyl20, @bgamari Could you review this too? :)

Copy link
Contributor

@hsyl20 hsyl20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Bodigrim Bodigrim merged commit 4f5cc87 into haskell:master Jul 12, 2020
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sjakobi sjakobi deleted the warn-breaking-changes branch August 1, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants