-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog: Warn about upcoming breaking changes #220
Conversation
Suggestions to improve the wording of the note are very welcome! :) |
It does not hurt, but basically reiterates the fact that major versions bring breaking changes. If some people prefer not to put upper bounds beforehand, I do not think that such warning itself (even if read) will convince them to do otherwise, to be honest. To be a good citizen, I'd probably try to build a Stackage snapshot, once breaking changes have landed, and report failures to respective maintainers. |
@Bodigrim Regarding smoke-testing breaking changes, I've inquired about how to do this before, but never actually ended up doing it:
Luckily, once we've released a breaking change, the Stackage maintainers will eventually take of smoke-testing! ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording looks good to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One concern that frequently came up in discussions over breaking changes is that many packages currently don't specify an upper bound on
bytestring
. The note I'm adding here is meant to help remediate that situation.The planned breaking changes I'm currently aware of are:
and potentially the result of #140.