-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-throwing indexMaybe function (continues #146) #261
Conversation
Thanks for bringing it to the finish line ❤️ |
W. r. t. 02c54aa - please retain |
0ef93a4
to
2cd5ce9
Compare
I think I've implemented most of the outstanding comments from the previous review; the things I'm still unclear about are:
indexMaybe = (fmap w2c .) . B.indexMaybe
|
Let it be as is, it is potentially marginally better for inlining.
Yes, make it strict in all versions. |
This is a continuation of @FintanH's work in #146. I've rebased his commits onto the current
master
.