Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Don't fill ForeignPtrContents field with bottom #284

Merged
merged 1 commit into from
Sep 10, 2020
Merged

[master] Don't fill ForeignPtrContents field with bottom #284

merged 1 commit into from
Sep 10, 2020

Commits on Sep 10, 2020

  1. Don't fill ForeignPtrContents field with bottom 

    As noted in GHC #17290, ForeignPtrContents really should be strict.
With the addition of the FinalPtr constructor we now have a
sensible value to use in nullForeignPtr other than bottom.

Moreover, another unrelated GHC change (#17760) recently forced
the application of strictness for ForeignPtr's ForeignPtrContents
field. Consequently, we are making this change now. Unfortunately this
means that all earlier versions of bytestring will be unbuilable with
GHC >=9.0.
    @bgamari
    bgamari committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    ee9f5fc View commit details
    Browse the repository at this point in the history