Fix CI on Ubuntu 22.04 #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjakobi
approved these changes
Dec 7, 2022
Comment on lines
+26
to
+29
| - name: Install libncurses5 and libtinfo | ||
| if: runner.os == 'Linux' && matrix.ghc <= '8.2' | ||
| run: | | ||
| sudo apt-get install libncurses5 libtinfo5 |
There was a problem hiding this comment.
Shouldn't haskell/actions/setup provide these dependencies?! Is there an upstream ticket for this issue?
There was a problem hiding this comment.
I'm not really sure who is to blame. Presumably old ubuntu-20.04 runners had libncurses5 and libtinfo5 preinstalled, and new ubuntu-22.04 don't. But it's also possible that installation of GHC 8.0 via ghcup never worked properly on GHA; in such case haskell/actions/setup silently retries with ppa:hvr/ghc which succeeded. However, ppa:hvr/ghc does not contain packages for ubuntu-22.04, so now it fails.
clyring
approved these changes
Dec 7, 2022
clyring
pushed a commit
that referenced
this pull request
Dec 29, 2022
(cherry picked from commit 403d920)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by haskell/unix#266