Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive the globstar globbing patch #3178

Closed
23Skidoo opened this issue Feb 20, 2016 · 1 comment · Fixed by #5284
Closed

Revive the globstar globbing patch #3178

23Skidoo opened this issue Feb 20, 2016 · 1 comment · Fixed by #5284
Labels
type: enhancement

Comments

@23Skidoo
Copy link
Member

#2522 added support for globstar globbing (**/*) to extra-source-files and related fields; however the patch had some issues and wasn't merged. We should revive and finally merge it for the next Cabal release.
@23Skidoo 23Skidoo self-assigned this Feb 20, 2016
@23Skidoo 23Skidoo modified the milestones: Cabal 1.26, Cabal 1.24 Feb 20, 2016
@23Skidoo
Copy link
Member Author

@hvr told me that GHC 8 final will likely be delayed until the end of March, so maybe we'll have time to get this in.

@23Skidoo 23Skidoo modified the milestones: Cabal 1.26, Cabal 1.24 Mar 25, 2016
@23Skidoo 23Skidoo removed their assignment Jul 27, 2016
@ezyang ezyang modified the milestone: Cabal 2.0 Sep 6, 2016
@thumphries thumphries mentioned this issue Sep 27, 2016
Closed
quasicomputational added a commit to quasicomputational/cabal that referenced this issue Apr 25, 2018
@quasicomputational
Allow ** wildcards in globs.
8a00e00 
These are inspired by a plan described in a comment in haskell#2522, and only
implement a quite limited form of recursive matching: only a single **
wildcard is accepted, it must be the final directory, and, if a **
wildcard is present, the file name must include a wildcard.

Or-patterns are not implemented, for simplicity.

Closes haskell#3178, haskell#2030.
@quasicomputational quasicomputational mentioned this issue Apr 25, 2018
Merged
4 tasks
quasicomputational added a commit to quasicomputational/cabal that referenced this issue Apr 25, 2018
@quasicomputational
Allow ** wildcards in globs.
7210b68 
These are inspired by a plan described in a comment in haskell#2522, and only
implement a quite limited form of recursive matching: only a single **
wildcard is accepted, it must be the final directory, and, if a **
wildcard is present, the file name must include a wildcard.

Or-patterns are not implemented, for simplicity.

Closes haskell#3178, haskell#2030.
quasicomputational added a commit to quasicomputational/cabal that referenced this issue Apr 28, 2018
@quasicomputational
Allow ** wildcards in globs.
bc4d27f 
These are inspired by a plan described in a comment in haskell#2522, and only
implement a quite limited form of recursive matching: only a single **
wildcard is accepted, it must be the final directory, and, if a **
wildcard is present, the file name must include a wildcard.

Or-patterns are not implemented, for simplicity.

Closes haskell#3178, haskell#2030.
quasicomputational added a commit to quasicomputational/cabal that referenced this issue Apr 29, 2018
@quasicomputational
Allow ** wildcards in globs.
351903e 
These are inspired by a plan described in a comment in haskell#2522, and only
implement a quite limited form of recursive matching: only a single **
wildcard is accepted, it must be the final directory, and, if a **
wildcard is present, the file name must include a wildcard.

Or-patterns are not implemented, for simplicity.

Closes haskell#3178, haskell#2030.
quasicomputational added a commit to quasicomputational/cabal that referenced this issue May 6, 2018
@quasicomputational
Allow ** wildcards in globs.
6930a8d 
These are inspired by a plan described in a comment in haskell#2522, and only
implement a quite limited form of recursive matching: only a single **
wildcard is accepted, it must be the final directory, and, if a **
wildcard is present, the file name must include a wildcard.

Or-patterns are not implemented, for simplicity.

Closes haskell#3178, haskell#2030.
23Skidoo pushed a commit that referenced this issue May 8, 2018
@quasicomputational @23Skidoo
Allow ** wildcards in globs.
5e83ef2 
These are inspired by a plan described in a comment in #2522, and only
implement a quite limited form of recursive matching: only a single **
wildcard is accepted, it must be the final directory, and, if a **
wildcard is present, the file name must include a wildcard.

Or-patterns are not implemented, for simplicity.

Closes #3178, #2030.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow ** wildcards in globs. quasicomputational/cabal
2 participants
@ezyang @23Skidoo