-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9815: fix caching for quick-jobs CI (XDG, cache keys) (backport #9845) #10041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #9815: - Cache `~/.local/state/cabal` instead of `~/.cabal/store` - `~/.local/bin` is used instead of `~/.cabal/bin` and is already in the PATH (verify this by calling `alex` after installing it) As I am passing by: - bump cache action to v4 - double-quote `$USER` to keep actionlint happy - move `if` from shell-level to job-level - allow newest `alex` (cherry picked from commit e916cb5)
(cherry picked from commit c209a82)
(cherry picked from commit 56426e4)
(cherry picked from commit 9a311bd)
(cherry picked from commit ba6f6ff)
(cherry picked from commit 5949e3f)
Not sure why this was not up to date on master and still CI passed. Maybe the content of this file is dependent on the GHC version we are using to build the `get-cabal-macros` tool? (cherry picked from commit 947860a)
(cherry picked from commit 5aa8afd)
2 tasks
2 tasks
This is mutually CI-blocking with #10043 so, if nobody objects, let's merge this manually with red CI. |
I think merging the other one (#10043) manually is better because that one is simpler. |
Hopefully, my manual conflict resolution went well... |
ulysses4ever
approved these changes
May 23, 2024
@mergify rebase |
❌ Base branch update has failedGit reported the following error:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9815:
~/.local/state/cabal
instead of~/.cabal/store
~/.local/bin
is used instead of~/.cabal/bin
and is already in the PATH(verify this by calling
alex
after installing it)As I am passing by:
$USER
to keep actionlint happyif
from shell-level to job-levelalex
UPDATE: This PR has been extended to
lexer
goal in theMakefile
(was removed in Add alex to build-tool-depends remove separate code gen #8980).PHONY
systematically inMakefile
This is an automatic backport of pull request #9845 done by [Mergify](https://mergify.com).