[3.12] PackageTests/NewUpdate: fix skipping flaky tests #10045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
May 23, 2024
bacchanalia
force-pushed
the
zz/fix-flaky-tests-3.12
branch
from
5515248
to
cc85b3b
Compare
|
If nobody objects, I'm going to expedite the merge to shorten the period we are getting the spurious CI errors. |
|
@Mikolaj backports are exempt from the two-days delay anyway. The bot shall merge it once CI passes |
|
@mergify refresh |
✅ Pull request refreshed |
Mikolaj
force-pushed
the
zz/fix-flaky-tests-3.12
branch
from
cc85b3b
to
c0ea4ba
Compare
|
This has to wait for |
ulysses4ever
force-pushed
the
zz/fix-flaky-tests-3.12
branch
from
c0ea4ba
to
82bf23b
Compare
RejectFutureIndexStates and UpdateIndexState are marked "skip", but it's under withRemoteRepo, which causes flakiness before skip is called.
ulysses4ever
force-pushed
the
zz/fix-flaky-tests-3.12
branch
from
82bf23b
to
643cd64
Compare
ulysses4ever
pushed a commit
to ulysses4ever/cabal
that referenced
this pull request
Jun 3, 2024
…3.12 [3.12] PackageTests/NewUpdate: fix skipping flaky tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RejectFutureIndexStates and UpdateIndexState are marked "skip", but it's under withRemoteRepo, which causes flakiness before skip is called.
backport of #10035