new-install: error on existing symlink, overwrite option #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgaz
commented
Oct 25, 2018
fgaz
commented
Oct 25, 2018
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "10f5a983ce727e9e745cbcf154e80c6817301b13", "tag":"linux-8.0.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "10f5a983ce727e9e745cbcf154e80c6817301b13", "tag":"linux-7.8.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "10f5a983ce727e9e745cbcf154e80c6817301b13", "tag":"linux-7.10.3" }
fgaz
force-pushed
the
new-install/error-symlink
branch
from
10f5a98
to
446be82
Compare
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "446be82f50735871092e9f7434c24aa782227f01", "tag":"linux-7.10.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "446be82f50735871092e9f7434c24aa782227f01", "tag":"linux-8.0.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "446be82f50735871092e9f7434c24aa782227f01", "tag":"linux-7.8.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "446be82f50735871092e9f7434c24aa782227f01", "tag":"linux-8.2.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "446be82f50735871092e9f7434c24aa782227f01", "tag":"linux-7.6.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "446be82f50735871092e9f7434c24aa782227f01", "tag":"linux-8.4.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "446be82f50735871092e9f7434c24aa782227f01", "tag":"linux-8.4.4-fdebug-expensive-assertions" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "446be82f50735871092e9f7434c24aa782227f01", "tag":"osx-7.8.4" }
fgaz
force-pushed
the
new-install/error-symlink
branch
from
446be82
to
7f13951
Compare
Before, new-install could exit successfully while actually _not_ symlinking anything. Moreover, without an overwrite option, upgrading cabal was impossible without moving links around. * Error out on overwrite * Overwrite if --force-overwrite is passed
fgaz
force-pushed
the
new-install/error-symlink
branch
from
7f13951
to
a3d222d
Compare
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "a3d222d2a7581465b902ba1962d7c56f45a66e7c", "tag":"linux-7.10.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "a3d222d2a7581465b902ba1962d7c56f45a66e7c", "tag":"linux-7.8.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "a3d222d2a7581465b902ba1962d7c56f45a66e7c", "tag":"linux-8.2.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "a3d222d2a7581465b902ba1962d7c56f45a66e7c", "tag":"linux-8.0.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "a3d222d2a7581465b902ba1962d7c56f45a66e7c", "tag":"linux-7.6.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "a3d222d2a7581465b902ba1962d7c56f45a66e7c", "tag":"linux-8.4.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "a3d222d2a7581465b902ba1962d7c56f45a66e7c", "tag":"linux-8.4.4-fdebug-expensive-assertions" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 25, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "a3d222d2a7581465b902ba1962d7c56f45a66e7c", "tag":"osx-7.8.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 26, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "a3d222d2a7581465b902ba1962d7c56f45a66e7c", "tag":"osx-8.0.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 26, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "bf4b9c949a50a55bf91ee30df07437c9d956b9a8", "tag":"linux-7.10.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 26, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "bf4b9c949a50a55bf91ee30df07437c9d956b9a8", "tag":"linux-8.0.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 26, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "bf4b9c949a50a55bf91ee30df07437c9d956b9a8", "tag":"linux-7.8.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 26, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "bf4b9c949a50a55bf91ee30df07437c9d956b9a8", "tag":"linux-8.2.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 26, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "bf4b9c949a50a55bf91ee30df07437c9d956b9a8", "tag":"linux-7.6.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 26, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "bf4b9c949a50a55bf91ee30df07437c9d956b9a8", "tag":"linux-8.4.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 26, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "bf4b9c949a50a55bf91ee30df07437c9d956b9a8", "tag":"linux-8.4.4-fdebug-expensive-assertions" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 26, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "bf4b9c949a50a55bf91ee30df07437c9d956b9a8", "tag":"osx-7.8.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 26, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "bf4b9c949a50a55bf91ee30df07437c9d956b9a8", "tag":"osx-8.0.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 28, 2018
"url":"pull/5638", "account":"haskell", "repo":"cabal", "commit": "bf4b9c949a50a55bf91ee30df07437c9d956b9a8", "tag":"osx-7.10.3" }
|
I gave this PR a test-run, and it appears to work reasonably. There's some minor aesthetic issues with some messages which e.g. claim that a "Symlink" already exists even though it's not a symlink but a regular file... but there's a few more (not high prio) UI details we might want to improve/fix there that this can be addressed by a future PR |
23Skidoo
approved these changes
Oct 29, 2018
| "Overwrite an existing symlink." | ||
| ninstForceOverwrite (\v flags -> flags { ninstForceOverwrite = v }) | ||
| trueArg | ||
| , option [] ["overwrite-policy"] |
There was a problem hiding this comment.
We can also make it work similarly to --allow-newer, i.e. make --overwrite-symlink w/o arguments be a shortcut for --overwrite-symlink=always.
There was a problem hiding this comment.
@23Skidoo btw, didn't we want to deprecate the option-less --allow-newer variant? :)
also, are you implying a suggestion of renaming --overwrite-policy=... to --overwrite-symlink=...?
There was a problem hiding this comment.
oh and btw, I'd like to point out that during dogfooding I started using an abbrev, like e.g.
cabal v2-install alex --overwrite=always
or even
cabal v2-install alex --over=always
There was a problem hiding this comment.
@23Skidoo after thinking about this, the decision whether to support an argument less --overwrite-... hinges on what default we want to pick. I.e. if we default to always it'd be confusing to have a seemingly no-op alias which just reaffirms the default setting; thus I'd suggest to postpone adding a shortcut to this PR, and put it up for vote together with the decision for which default we want to pick for the benefit of interactive shell users
There was a problem hiding this comment.
thus I'd suggest to postpone adding a shortcut to this PR
Sure. Let's merge.
[ci skip]
|
Merged, thanks! |
23Skidoo
added a commit
that referenced
this pull request
Oct 30, 2018
new-install: error on existing symlink, overwrite option (cherry picked from commit a0684df)
|
Also cherry-picked to 2.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 2 of the fix for #5491. Followup to #5602.
Erroring out is safer and more explicit.
Next, we'll have to check for error/no-op as early as possible (currently we build everything first).
/cc @hvr