Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haddock failures should be fatal when running Haddock #6136

Closed
wants to merge 1 commit into from

Conversation

isovector
Copy link
Contributor

@isovector isovector commented Jul 7, 2019

I am reasonably sure this fixes #5977. I have no idea how to test it, as I'm a stack user.


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@phadej
Copy link
Collaborator

phadej commented Jul 7, 2019

Thanks Sandy for finding a spot. I'll take over.

#6137 with added test is up.

@phadej phadej closed this Jul 7, 2019
@phadej phadej mentioned this pull request Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal v2-haddock exits with 0 even when it fails to build the docs
2 participants