haddock-packages fixes #9213
haddock-packages fixes #9213
Conversation
This patch fixes a bug where a sublibrary overwrites a library directory. This leads to overwriting `*.haddock` files, which results in missing entries in various indexes (e.g. the html index, quicksearch).
|
@coot You didn't get a notification here? #9088 (comment) |
cabal-testsuite/PackageTests/Backpack/Includes2/setup-external.out
Outdated
Show resolved
Hide resolved
|
@Kleidukos it was here. |
|
@coot yes sorry, I meant to ping you there to show you that it was quite hard to get this fix backported. But perhaps this PR will be more lucky! :) |
coot
force-pushed
the
coot/haddock-package-fixes-3.10
branch
from
21b4ff4
to
e0f6a5f
Compare
|
Yes, it wasn't easy because of the style changes that got in the way 😁. |
|
@coot looks like we're not escaping this problem: https://github.com/haskell/cabal/actions/runs/5991249840/job/16249404279?pr=9213 |
This patch makes `haddock-project` use `--local` option by default. Since its the default, it is removed. Also `--gen-index`, `--gen-contents`, `--hyperlinked-source` and `--quickjump` are removed since they are always turned on. Added a haddock-project test.
coot
force-pushed
the
coot/haddock-package-fixes-3.10
branch
from
e0f6a5f
to
e23e212
Compare
|
It should be fixed now, I updated |
|
@coot It seems to me that the Whitespace check has failed, would you mind fixing that one? I'll merge your PR once my plane lands. :) |
`haddock-project` command need to build the project so that haddocks of the dependencies are available in the store. Fixes #8958.
coot
force-pushed
the
coot/haddock-package-fixes-3.10
branch
from
316f077
to
e720627
Compare
Kleidukos
added
squash+merge me
|
@coot Dziękuję bardzo! |
Good call. Given the size, though, I'd test it especially hard in the alpha release and, if things don't play out, we can always revert before the release. |
|
I tested |
Backport for 3.10.2.0
Cherry-picked commits from #8919.
@Mikolaj I asked in another PR but didn't got an answer if this will be accepted; I took a risk and created this PR.