Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell zlib not to use pkg-config #9775

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

chreekat
Copy link
Collaborator

@chreekat chreekat commented Mar 4, 2024

(In GitLab CI)

GitLab pipeline status

@chreekat
Copy link
Collaborator Author

chreekat commented Mar 4, 2024

Hm, something weird happening on the Windows build. Looks like something else is trying to restart it, too, but I don't know what (or who?)

@Kleidukos
Copy link
Member

@chreekat would you mind adding this badge to the README? <3

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Mikolaj Mikolaj added continuous-integration release re: pkg-config Concerning pkg-config and pkgconfig-depends constraints labels Mar 4, 2024
@chreekat
Copy link
Collaborator Author

chreekat commented Mar 5, 2024

The failure on Windows sorta looks like it might be GHC's fault, but that is just my initial hunch.

To be systematic:

The error happens right at the end of the build. A successful build (e.g. https://gitlab.haskell.org/haskell/cabal/-/jobs/1797207) ends with:

Configuring executable 'cabal' for cabal-install-3.11.0.0..
Preprocessing executable 'cabal' for cabal-install-3.11.0.0..
Building executable 'cabal' for cabal-install-3.11.0.0..
[1 of 1] Compiling Main             ( main/Main.hs, /builds/haskell/cabal/dist-newstyle/build/aarch64-linux/ghc-9.2.3/cabal-install-3.11.0.0/x/cabal/build/cabal/cabal-tmp/Main.o )
Linking /builds/haskell/cabal/dist-newstyle/build/aarch64-linux/ghc-9.2.3/cabal-install-3.11.0.0/x/cabal/build/cabal/cabal ...
Uploading artifacts for successful job
Cleaning up project directory and file based variables
Job succeeded

But the Windows job ends with

Configuring executable 'cabal' for cabal-install-3.11.0.0..
Preprocessing executable 'cabal' for cabal-install-3.11.0.0..
Building executable 'cabal' for cabal-install-3.11.0.0..
[1 of 1] Compiling Main             ( main\Main.hs, C:\\GitLabRunner\builds\0\1797238\dist-newstyle\build\x86_64-windows\ghc-9.2.3\cabal-install-3.11.0.0\x\cabal\build\cabal\cabal-tmp\Main.o )
Linking C:\\GitLabRunner\\builds\\0\\1797238\\dist-newstyle\\build\\x86_64-windows\\ghc-9.2.3\\cabal-install-3.11.0.0\\x\\cabal\\build\\cabal\\cabal.exe ...
Cleaning up project directory and file based variables
ERROR: Job failed: exit status 127

So I guess this means cabal-install is exiting with status 127. I don't know what that means.

@chreekat
Copy link
Collaborator Author

chreekat commented Mar 5, 2024

The bug could also be with zlib.

In 0.6.3.0, zlib uses the vendored libz C library on Windows. In 0.7.0.0, when disabling pkg-config, it just uses extra-libraries: z, claiming in a comment that "On Windows, zlib is shipped with GHC starting from 7.10".

I'm gonna see if going back to using the vendored libz fixes the Windows build.

@chreekat
Copy link
Collaborator Author

chreekat commented Mar 5, 2024

Lord almighty, the Darwin job is building LLVM or something?! Amazing

@chreekat
Copy link
Collaborator Author

chreekat commented Mar 5, 2024

GitLab CI passed, so I will send to the bot.

@chreekat chreekat added the merge me Tell Mergify Bot to merge label Mar 5, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Mar 7, 2024
@mergify mergify bot merged commit 3d881ac into haskell:master Mar 7, 2024
53 checks passed
@Mikolaj
Copy link
Member

Mikolaj commented Apr 26, 2024

@mergify backport 3.12

Copy link
Contributor

mergify bot commented Apr 26, 2024

backport 3.12

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge re: pkg-config Concerning pkg-config and pkgconfig-depends constraints release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants