Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement map/coerce for IntMap #71

Merged
merged 1 commit into from
Nov 21, 2014
Merged

Conversation

treeowl
Copy link
Contributor

@treeowl treeowl commented Nov 19, 2014

I realized what I was doing with MIN_VERSION was kind of silly.
The easy/sane thing to do is really to use GLASGOW_HASKELL
for the coercion stuff.

I realized what I was doing with MIN_VERSION was kind of silly.
The easy/sane thing to do is really to use __GLASGOW_HASKELL__
for the coercion stuff.
@foxik
Copy link
Contributor

foxik commented Nov 19, 2014

Thanks :-) If we are going to use __GLASGOW_HASKELL__ for coercion stuff (which we probably should), could you please also add commits which replace MIN_VERSION_base(4,8,0) in Map.Base, Map.Strict, Sequence and Tree?

@treeowl
Copy link
Contributor Author

treeowl commented Nov 19, 2014

Yes, of course. I was planning to do that in a separate pull request.

@foxik
Copy link
Contributor

foxik commented Nov 21, 2014

I probably misunderstand your comment -- even though you "planned to do that in a separate pull request", I thought you will add the changes here, but you are probably waiting for me to merge this and want to do it later.

I am merging now, but leaving this pull request open to remind me that __GLASGOW_HASKELL__ and coercion still need to be sorted.

Thank you very much for all your work on containers!

foxik added a commit that referenced this pull request Nov 21, 2014
Implement map/coerce for IntMap
@foxik foxik merged commit bcebc7a into haskell:master Nov 21, 2014
@foxik
Copy link
Contributor

foxik commented Nov 21, 2014

It seems I cannot keep pull request opened after merging. Moving the remainder to a corresponding issue.

@treeowl
Copy link
Contributor Author

treeowl commented Nov 21, 2014

Yes, my git-fu is very weak; I didn't want to try figuring out how to add commits to a pull request or whatever. I should definitely be able to put together a new one today.

@foxik
Copy link
Contributor

foxik commented Nov 21, 2014

Thanks :-)

@treeowl treeowl deleted the fmapcoerceintmap branch November 21, 2014 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants