This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Speed up span lookups #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
force-pushed
the
span-lookups
branch
from
f4c24dc
to
6146f5f
Compare
|
@pepeiborra this is great! Do you have some measurements of improvement? |
|
Very hard to measure, due to #254 (comment) |
|
@pepeiborra seems like that's fixed. |
|
No real speed up observed. Fail. Looking up spans in a list is (unsurprisingly) way less expensive than type checking; I suspect that a module with enough spans to make the lookup operation noticeably slow would run out of memory during type checking. I'll revert the interval tree change and keep just the fix for #247 EDIT: my performance tests are here: pepeiborra@f23b5ef |
pepeiborra
force-pushed
the
span-lookups
branch
from
6146f5f
to
d96f4ca
Compare
pepeiborra
force-pushed
the
span-lookups
branch
from
d96f4ca
to
8f0fa4c
Compare
pepeiborra
added a commit
to pepeiborra/ghcide
that referenced
this pull request
Feb 1, 2020
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the first part of the discussion in #101,
and reusing some code from https://github.com/mpickering/ghcide/commits/wip/type-map.
An interval tree is used to speed up span lookups, which benefits hovers and
definition lookups. The computation of spans is still done using the same
algorithm as previously.
Fixes #247 by sorting matching spans by relevance.