This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
force-pushed
the
outline
branch
2 times, most recently
from
December 29, 2019 19:32
7a967aa
to
2ef8029
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is great!
Some small comments.
Co-Authored-By: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com>
No longer relying on gfindtype
aherrmann-da
approved these changes
Dec 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing these!
pepeiborra
added a commit
to pepeiborra/ghcide
that referenced
this pull request
Jan 3, 2020
* Document symbols provider * Compatibility with GHC 8.4 * Replace large number with more descriptive maxBound Co-Authored-By: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com> * Use SkFunction for all Val Declarations * Improve outlining of PatBind and FunBind No longer relying on gfindtype Co-authored-by: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com>
pepeiborra
added a commit
to pepeiborra/ghcide
that referenced
this pull request
Feb 1, 2020
* Document symbols provider * Compatibility with GHC 8.4 * Replace large number with more descriptive maxBound Co-Authored-By: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com> * Use SkFunction for all Val Declarations * Improve outlining of PatBind and FunBind No longer relying on gfindtype Co-authored-by: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com>
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Document symbols provider * Compatibility with GHC 8.4 * Replace large number with more descriptive maxBound Co-Authored-By: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com> * Use SkFunction for all Val Declarations * Improve outlining of PatBind and FunBind No longer relying on gfindtype Co-authored-by: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com>
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Document symbols provider * Compatibility with GHC 8.4 * Replace large number with more descriptive maxBound Co-Authored-By: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com> * Use SkFunction for all Val Declarations * Improve outlining of PatBind and FunBind No longer relying on gfindtype Co-authored-by: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com>
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Document symbols provider * Compatibility with GHC 8.4 * Replace large number with more descriptive maxBound Co-Authored-By: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com> * Use SkFunction for all Val Declarations * Improve outlining of PatBind and FunBind No longer relying on gfindtype Co-authored-by: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low hanging fruit, worth doing as VS Code makes document outlines actually useful by adorning them with warnings and errors markers.