This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Better progress messages #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocreature
approved these changes
Feb 3, 2020
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Require shake-0.18.4 which contains actionBracket * Change progress reporting to use files rather than Shake nodes * Remove inadvertantly writing down Shake twice
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Require shake-0.18.4 which contains actionBracket * Change progress reporting to use files rather than Shake nodes * Remove inadvertantly writing down Shake twice
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Require shake-0.18.4 which contains actionBracket * Change progress reporting to use files rather than Shake nodes * Remove inadvertantly writing down Shake twice
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of saying how many nodes are in the Shake graph, we instead say how many files have started in the Shake graph. Unlike the previous measure, it isn't guaranteed to be monotonically increasing, as you might start additional rules after running files. But, in practice it seems pretty good, as we're hooking in somewhere very low level, the numbers "have the right feel" - when I have a project open the number roughly corresponds to the number of files, and roughly feels like the work is checking files. It also has more overhead, but if that's a problem, could be redone in terms of IORef to avoid the Var.
Probably worth someone other than me also playing with it to confirm it "feels right".
Fixes #320