This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Performance analysis over time #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to mention that benchHist requires the changes in #625 |
pepeiborra
force-pushed
the
bench-hist
branch
3 times, most recently
from
4ef9f8f
to
79f0a10
Compare
Otherwise they tend to distort the axis
Otherwise the script is vulnerable to config edits
Handy for including bench-hist results in a branch while avoiding the intermediate artifacts
cocreature
approved these changes
Jun 15, 2020
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* benchmark history script * if HEAD no need to rebuild worktree * add bench/README.md * Enable all experiments * Fix dependency tracking for git branches * hlints * Add stack84 extra-deps * Identify failed experiments in graphs * Filter our failed benchmarks from aggregate graphs Otherwise they tend to distort the axis * Improve graphs (more and easier to see colors) * update cradles * customizable output folder * Cache the config for the duration of the script Otherwise the script is vulnerable to config edits * Allow omitting the git: field * Ignore bench-hist intermediate artifacts Handy for including bench-hist results in a branch while avoiding the intermediate artifacts
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* benchmark history script * if HEAD no need to rebuild worktree * add bench/README.md * Enable all experiments * Fix dependency tracking for git branches * hlints * Add stack84 extra-deps * Identify failed experiments in graphs * Filter our failed benchmarks from aggregate graphs Otherwise they tend to distort the axis * Improve graphs (more and easier to see colors) * update cradles * customizable output folder * Cache the config for the duration of the script Otherwise the script is vulnerable to config edits * Allow omitting the git: field * Ignore bench-hist intermediate artifacts Handy for including bench-hist results in a branch while avoiding the intermediate artifacts
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* benchmark history script * if HEAD no need to rebuild worktree * add bench/README.md * Enable all experiments * Fix dependency tracking for git branches * hlints * Add stack84 extra-deps * Identify failed experiments in graphs * Filter our failed benchmarks from aggregate graphs Otherwise they tend to distort the axis * Improve graphs (more and easier to see colors) * update cradles * customizable output folder * Cache the config for the duration of the script Otherwise the script is vulnerable to config edits * Allow omitting the git: field * Ignore bench-hist intermediate artifacts Handy for including bench-hist results in a branch while avoiding the intermediate artifacts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new script
benchHistto automate the running ofghcide-benchover multiple versions of the project, and produces.csvfiles and.svggraphs with the results. More details in the module header and the README.By default running
stack exec benchHistwill produce an analysis comparing HEAD with upstream, assuming everything works. The analysis is configurable via a yaml file.I have uploaded a sample output here: https://github.com/pepeiborra/ghcide/tree/bench-hist-dump/bench-hist
Some interesting results from the analysis:
Neil's Hashable PR really hit the leak right in the thunk:
Interface files did curb memory usage!
But they also made some things twice as slow (and I have a PR coming):
