Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Fix .hie file location for .hs-boot files #690

Merged
merged 4 commits into from
Sep 2, 2020
Merged

Fix .hie file location for .hs-boot files #690

merged 4 commits into from
Sep 2, 2020

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Jul 12, 2020

No description provided.

@pepeiborra
Copy link
Collaborator

What are .hie.boot files used for? Is there any way to write a test that will prevent this from breaking silently?

@wz1000
Copy link
Collaborator Author

wz1000 commented Jul 12, 2020

They are the same as .hie files, but are generated for .hs-boot files instead of .hs files. I will try to write a test for this, but it might be difficult since we don't use .hie files for much as of now.

@pepeiborra
Copy link
Collaborator

Goto definition is driven by .hie files, so maybe the test could leverage that

cocreature
cocreature reviewed Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As @pepeiborra said, a test for this would be great.

@wz1000
Copy link
Collaborator Author

wz1000 commented Jul 28, 2020

I discovered a bug where we were trying to load the wrong interface for hs-boot files (loading the hi file instead of the hi-boot file) which meant that the interfaces for boot files were regenerated every time.

To fix this, I moved all the logic for adding the -boot suffice to artifacts directly to where the ModSummarys are generated.

I've also added a testcase.

@pepeiborra pepeiborra merged commit 0350c7f into haskell:master Sep 2, 2020
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
@wz1000
Fix .hie file location for .hs-boot files (haskell/ghcide#690)
266992c 
* Find source for boot files

* fix modlocs for boot files

* Add test

* Fix build on 8.6
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
@wz1000
Fix .hie file location for .hs-boot files (haskell/ghcide#690)
955779c 
* Find source for boot files

* fix modlocs for boot files

* Add test

* Fix build on 8.6
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
@wz1000
Fix .hie file location for .hs-boot files (haskell/ghcide#690)
17455d1 
* Find source for boot files

* fix modlocs for boot files

* Add test

* Fix build on 8.6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cocreature cocreature cocreature left review comments

@pepeiborra pepeiborra pepeiborra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wz1000 @pepeiborra @cocreature