Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Use hie-bios-0.7.1 #763

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Use hie-bios-0.7.1 #763

merged 3 commits into from
Sep 8, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented Sep 4, 2020

  • To ensure we are able to set the stack.yaml in hie.yaml stack config

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ghcide.cabal Outdated Show resolved Hide resolved
ghcide.cabal Outdated Show resolved Hide resolved
@runeksvendsen
Copy link

Looks like hie-bios specifies a version bound of >= 0.8.32 for yaml while depending on its Data.Yaml.Internal module exporting Warning(..) but this requires at least 0.10.0.

@runeksvendsen
Copy link

I've reported this as a hie-bios bug: haskell/hie-bios#246

@fendor
Copy link
Collaborator

fendor commented Sep 6, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@jneira
Copy link
Member Author

jneira commented Sep 8, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@jneira
Copy link
Member Author

jneira commented Sep 8, 2020

I think we could merge this, without waiting to the hie-bios fix

@fendor
Copy link
Collaborator

fendor commented Sep 8, 2020

@jneira It is fixed on the hie-bios end with hackage revisions. The version bounds are fixed for version 0.7.0 and 0.7.1, sorry if I did not communicate that clearly

@jneira
Copy link
Member Author

jneira commented Sep 8, 2020

Dont worry, i did not check the linked issue neither.

@jneira jneira merged commit 9ae5134 into haskell:master Sep 8, 2020
@jneira jneira deleted the hie-bios-0.7.1 branch September 8, 2020 13:24
@jneira jneira mentioned this pull request Sep 14, 2020
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants